vasi1186 [vasi1186]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

The module description reminds me of http://drupal.org/project/int_meta. We review a module / theme per applicant; let us know which one you want reviewed.

	return array('administer node tags generator');

Please use spaces instead of tabs.

I will review the code within 6 days; for sure, I will not review it in the next 2 days.

1. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted.
2. The content of the file node_tags_generator.stopwords.inc doesn't seem to be UTF-8. Considering the file contains accented words, that could be a problem (PS: abbiomo is not an Italian word).

3.     case 'presave':{
         require_once("node_tags_generator.stopwords.inc");
   

   That code is looking for the file in the Drupal root directory. There is a Drupal function that should be used in such cases.

4. /**
    * Implementation of hook_install
    *
    */
   function node_tags_generator_install(){
     //ensure that the weight of the module is bigger than the weight of the taxonomy module
     switch ($GLOBALS['db_type']) {
       case 'mysql':
       case 'mysqli': {
           $taxonomy_weight = db_result(db_query("SELECT weight FROM {system} WHERE name='taxonomy'"));
           db_query("UPDATE {system} SET weight=%d WHERE name='node_tags_generator'", $taxonomy_weight+1);
         break;
       }
       case 'pgsql':{
           $taxonomy_weight = db_result(db_query("SELECT weight FROM {system} WHERE name='taxonomy'"));
           db_query("UPDATE {system} SET weight=%d WHERE name='node_tags_generator'", $taxonomy_weight+1);
         break;
       }
     }
   }
   

   The code is still in style Drupal 5; apart that, the queries are the same.

5. function node_tags_generator_form_alter(&$form, &$form_state, $form_id){
     if (strpos($form_id, "_node_form") !== FALSE){
   

   That condition is not enough to verify if the form is the node form (there could be other forms with an ID ending in _node_form.

6. Strings used in the user interface should be in sentence case.

7.   if (!module_exists('taxonomy')){
       return t('Taxonomy module must be enabled in order to use this module.');
     }
   

   That code is useless; as the module requires taxonomy.module, it cannot be enabled without to enable first taxonomy.module.

8. Settings that depend on the content type are added to the content type editing form.