Argument empty should be able to check for NULL [#741234]

The same problem occurs when using a negativ argument filter i.e. checking "exclude argument". If there are null values in the column the null rows are regarded as having(!) the excluded value. This is commonly not desired.

The SQL Code is
... WHERE field != 'x' ...

and should be
... WHERE field != 'x' OR field IS NULL

Sorry, but I am not responsible for his ugly SQL behaviour.

Comment	File	Size	Author
#8	741234_views_empty_arg_check_null.patch	1.5 KB	dawehner
#7	741234_views_empty_arg_check_null.patch	2.6 KB	dawehner
#4	741234_views_empty_arg_check_null.patch	1.19 KB	voxpelli

Comments

Comment #1

skylord commented 22 April 2010 at 08:27

subscribing
For excluding argument i use a simple patch to handlers/views_handler_argument_numeric.inc:

--- handlers/views_handler_argument_numeric.inc.orig    2010-04-22 12:03:06.000000000 +0400
+++ handlers/views_handler_argument_numeric.inc 2010-04-22 12:10:27.000000000 +0400
@@ -84,11 +84,11 @@
     if (count($this->value) > 1) {
       $operator = empty($this->options['not']) ? 'IN' : 'NOT IN';
       $placeholders = implode(', ', array_fill(0, sizeof($this->value), '%d'));
-      $this->query->add_where(0, "$this->table_alias.$this->real_field $operator ($placeholders)", $this->value);
+      $this->query->add_where(0, "$this->table_alias.$this->real_field $operator ($placeholders)" . (empty($this->options['not']) ? '' : " OR $this->table_alias.$this->real_field IS NULL"), $this->value);
     }
     else {
       $operator = empty($this->options['not']) ? '=' : '!=';
-      $this->query->add_where(0, "$this->table_alias.$this->real_field $operator %d", $this->argument);
+      $this->query->add_where(0, "$this->table_alias.$this->real_field $operator %d" . (empty($this->options['not']) ? '' : " OR $this->table_alias.$this->real_field IS NULL"), $this->argument);
     }
   }
 }