Is there a reason to use urlencode instead of drupal's inner function drupal_urlencode?

Comments

Steven’s picture

Steven CreditAttribution: Steven commented
Status: Active » Fixed

Nope, just an oversight. Fixed in CVS.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)
fonant’s picture

fonant CreditAttribution: fonant commented

I think this was changed in error, as the query string shouldn't need the double-encoding required in the main URL when clean URLs are on (to work around mod_rewrite's decoding).

I think drupal_urlencode should in fact not be used here, to avoid the double-encoding problems. Instead we should revert to urlencode(), or, perhaps better, rawurlencode() as used in drupal_urlencode().

Resulting issue?: http://drupal.org/node/285496

fonant’s picture

fonant CreditAttribution: fonant commented

And other issues that are the result of this change?

http://drupal.org/node/178615 <- The main issue
http://drupal.org/node/221915