danjukes [danjukes]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

Some, but probably not all, things to improve. Please note that some of the things listed are just examples and there may be multiple occurrences to fix.

1. ; $Id: save_draft.info,v 1.0 2010/03/10 16:21:00 danjukes Exp $
   

   Should be just "$Id$" as the CVS d.o packaging will handle this.

2. Follow Drupal coding standards and use Coder: http://drupal.org/coding-standards http://drupal.org/project/coder
3. Use docblocks for all functions.
4. It seems like you are rewriting the node submit and saving functions here. You should just be leveraging the usual submit function after setting the published property. I don't have the API in front of me right now, but you should be able to leverage a function to handle of most of this.

Overall, fairly-well written, helpful, little module. Keep up the good work.

Things to do for CVS access:

1. Have a basic README.txt

2. /**
    * Implementation of hook form alter to add the save as draft button
    */
   

   Should be the following. (With hook docblocks, you just want to reference the hook.)

   /**
    * Implements hook_form_alter().
    */
   

Suggestions

1. Port to Drupal 6. I would use this in a number of my sites. :)

Good work. Should be ready next time around.

Looks good. Great work! Can't wait to use this one.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.