CVS edit link for sTr

I want to build an addon for swf-tools. This addon is using the sgf-files player GoSWF http://www.gludion.com/go/ to replay Go-Games. An early alpha version of this addon is already running under www.digoc.de

Also i like to contribute some themes in the future.

CommentFileSizeAuthor
#4 preset-size.jpeg9.48 KBichderfisch
#4 goswf.jpeg52.45 KBichderfisch
#2 goswf.zip3.15 KBichderfisch
#1 goswf.zip2.8 KBichderfisch

Comments

ichderfisch’s picture

ichderfisch commented
StatusFileSize
new goswf.zip2.8 KB

My first version of the goswf module to replay sgf-files (Annotation Files of the Board-Game Go)

ichderfisch’s picture

ichderfisch commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new goswf_rev.zip3.15 KB

Updated Version

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

ichderfisch’s picture

ichderfisch commented
StatusFileSize
new goswf.jpeg52.45 KB
new preset-size.jpeg9.48 KB

Thank you.
Here my reviewed motivation message.

My module is an addon for SWF-Tools. As already said it uses the GoSWF-Player to replay Go-Games (http://www.gludion.com/go/). Go is an ancient chinese board game, still played today by millions of people all over the world, mostly in Asia, but also in Europe and North America. In the near future I'm going to build at least three webpages with Go as main topic, so I build this module to easily integrate GoSWF as my standard player to replay Go-Games. Go-Game annotations exist in small SGF-Files.

Actually until today there is no other option to replay Go-Games on a Drupal System. The first final version of my modul will easily integrate GoSWF to Drupal using SWF-Tools. Because of the SWF-Tools Features it is possible to display SGF-Files in all standard SWF-Tools settings, for example using CCK-Filefield Display Field Settings or the [swf]-Tags. Also there will be an option to costumize the Look & Feel Settings (Color and Size) via the Backend (already working in the latest rev). For the easy-to-use handling of GoSWF there will be the possibility to choose between different presettings, like color- and size-schemes (already working on my local machine - see screenshot).

how go-swf looks like, when it is running you can see on the second screenshot or www.digoc.de where i'm already using GoSWF.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno

I am assigning the report to me as I will review it tomorrow morning (which means in less than 24 hours from now).

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed 
  1. version = "6.x-1.x-dev"
core = "6.x"
project = "swftools"
datestamp = "1240829764"

    Those lines needs to be removed, as they are already added by the packaging script; duplicating those lines would confuse the updates manager.

  2. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be written.
  3. Strings used in the user interface should be in sentence case.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Module review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Issue summary: View changes