CVS edit link for Cyberwolf

Hi

I would like to contribute a module that exposes location data (from the location module) as facets for the faceted_search module, as well as a module with a new imagecache action that executes all actions from another preset (see http://drupal.org/node/699154).

CommentFileSizeAuthor
#2 location_facets.tgz2.76 KBcyberwolf

Comments

Anonymous’s picture

Anonymous (not verified) commented

Hello, and thanks for applying for a CVS account.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.
The archive containing the proposed module / theme should then be attached to a comment here.

cyberwolf’s picture

cyberwolf commented
StatusFileSize
new location_facets.tgz2.76 KB

The ImageCache Preset action will be part of the ImageCache Actions project, see http://drupal.org/node/734352.

Attached is Location Facets. It exposes country and city of locations associated with nodes by the Location module, as facets for Faceted Search.
I believe it's better to have a separate project for this, as a website that needs Location does not necessarily needs Faceted Search and vice versa. There are also other modules exposing new facets living outside the Faceted Search project, like CCK Facets and Organic Groups Facets.

cyberwolf’s picture

cyberwolf commented
Status: Postponed (maintainer needs more info) » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Module review

The motivation message still needs to be expanded as reported in comment #1.

cyberwolf’s picture

cyberwolf commented

Brief demonstration video: http://www.screencast.com/t/MDc0ZjQ1NmY

Extract from readme (also contained in the attachment previously uploaded):

Description
***********

Location Facets exposes geographical information associated with Drupal nodes
as facets for the Faceted Search module. For its geographical information
Location Facets relies on the Location module.

Location Facets currently only exposes regular locations associated with nodes,
it does not support CCK Location fields.

Requirements
************

- Drupal 6.x (http://drupal.org/project/drupal).

- Faceted Search (http://drupal.org/project/faceted_search).

- Location (http://drupal.org/project/location).

Installation
************

1. Extract the location_facets package into your Drupal modules directory.

2. Go to the Administer > Site building > Modules page, and enable the Location
Facets module.

3. Go to the Administer > Site configuration > Faceted Search page, edit the
faceted search environment that shall expose the Location-based facet. In the
environment editing form, check the location facet.

jamesfk’s picture

jamesfk commented

Brilliant idea +1 from me, I already have a couple of sites which could use this feature.

Good luck with the project, and I will be very happy to be a test case for you...

cyberwolf’s picture

cyberwolf commented
Status: Needs work » Needs review
jamesfk’s picture

jamesfk commented

Just a note to say I am now using this on a site in development and it is working very well - I hope this can be made into an official module asap. I plan to use it on another site very soon too - thanks for the work!

cyberwolf’s picture

cyberwolf commented

Hi jamesfk, glad to hear the module was already useful for you!

cyberwolf’s picture

cyberwolf commented

Still waiting for my request to be further processed. Anyone out there having some time to help me progress, please?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community 
  require_once './' . drupal_get_path('module', 'faceted_search') . '/faceted_search.inc';

The function to use is module_load_include(); it is then better to include the file when it is really necessary, rather than globally including it.

The rest of the code follows the coding standards, and use the correct functions.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lucascaro’s picture

lucascaro commented

I can't find this module in the contributed modules directory. Did you get cvs access? This module sounds super useful. I'm using it already. and would like to be able to track the development.

thanks!

cyberwolf’s picture

cyberwolf commented

I did not have time yet to commit it, but will try to do it soon. Stay tuned!

cyberwolf’s picture

cyberwolf commented

I created the project: http://drupal.org/project/location_facets. Will try to release a dev version ASAP.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes