IMHO, comments should only show up in the RSS feed if the parent node has comments enabled. If comments are disabled, they shouldn't appear. This patch implements that feature.

CommentFileSizeAuthor
#4 Drupal.comment.rss.display.patch_0.txt813 bytesGábor Hojtsy
#1 Drupal.comment.rss.display.patch.txt792 bytesGábor Hojtsy
comment_rss_item.patch.txt556 bytesKris Jenkins
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Title: Small improvement to comments 'rss item' display. » Only display comment link in RSS, if applicable
Status: Needs review » Reviewed & tested by the community
FileSize
Drupal.comment.rss.display.patch.txt792 bytes

Your coding style was not Drupal conform. I have updated the patch, and I think it is RTBC.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Version: 4.7.2 » x.y.z

Patch is for the cvs HEAD version.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs review

Better to write?
$node->comment != COMMENT_NODE_DISABLED

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Reviewed & tested by the community
FileSize
Drupal.comment.rss.display.patch_0.txt813 bytes

Better indeed.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)