Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
5 Mar 2010 at 02:46 UTC
Updated:
29 Jul 2014 at 18:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Crell commentedSubscribing.
Comment #2
carlos8f commentedSubscribing, should hopefully be straightforward.
Comment #3
atchijov commentedNot sure if I have submitted diff in right format. Where can I look for "rules of engagement"?
Comment #5
catchRoll with cvs diff -up to get it accepted by the bot (or bzr/git equivalent) - full instructions are at http://drupal.org/patch :)
Comment #6
carlos8f commentedDuring the installer this patch prevents about 200 parses with the standard profile, but there are still about 1000+ parses going on, which cannot be statically cached because they are mid-batch (and cache_set() is using FakeCache so that doesn't do any good either). We are parsing the same 100 or so files 10 times each during the batch, but I guess we'll have to re-address for D8.
Comment #7
catch#6: 733306-info-file-static-cache.patch queued for re-testing.
Comment #8
catchThis makes sense to me, I just profiled a request where drupal_parse_info_file() was being called twice for each theme (due to two calls to _system_rebuild_theme_data()), and parsing 15 .info files twice, took 250ms. So this patch would save around 125ms from that request.
Comment #9
Anonymous (not verified) commentedthe base flaw is we don't differentiate between a) "don't use a cache, go directly to the db" and b) "don't use a cache, parse most of the known universe, and the db, and the kitchen sink, because you can just never be too careful".
the module list page is an example where we want b) - if there are new files, we need to see them. for just about everything else, we really only need a).
Comment #10
catchComment #11
dries commentedThis looks good to me too. Committed to 7.x and 8.x.
Comment #12
bfroehle commentedUntagging since it's been committed to 7.x