Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.See http://drupal.org/node/686196#comment-2668760 and downwards for why. I doubt we have time to be doing heavy refactoring of the installer, so we should at least avoid the duplicate work, if not the duplicate function calls.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 733306-info-file-static-cache.patch | 938 bytes | carlos8f |
| #3 | node-733306-d7.diff | 539 bytes | atchijov |
Comments
Comment #1
Crell CreditAttribution: Crell commentedSubscribing.
Comment #2
carlos8f CreditAttribution: carlos8f commentedSubscribing, should hopefully be straightforward.
Comment #3
atchijov CreditAttribution: atchijov commentedNot sure if I have submitted diff in right format. Where can I look for "rules of engagement"?
Comment #5
catchRoll with cvs diff -up to get it accepted by the bot (or bzr/git equivalent) - full instructions are at http://drupal.org/patch :)
Comment #6
carlos8f CreditAttribution: carlos8f commentedDuring the installer this patch prevents about 200 parses with the standard profile, but there are still about 1000+ parses going on, which cannot be statically cached because they are mid-batch (and cache_set() is using FakeCache so that doesn't do any good either). We are parsing the same 100 or so files 10 times each during the batch, but I guess we'll have to re-address for D8.
Comment #7
catch#6: 733306-info-file-static-cache.patch queued for re-testing.
Comment #8
catchThis makes sense to me, I just profiled a request where drupal_parse_info_file() was being called twice for each theme (due to two calls to _system_rebuild_theme_data()), and parsing 15 .info files twice, took 250ms. So this patch would save around 125ms from that request.
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedthe base flaw is we don't differentiate between a) "don't use a cache, go directly to the db" and b) "don't use a cache, parse most of the known universe, and the db, and the kitchen sink, because you can just never be too careful".
the module list page is an example where we want b) - if there are new files, we need to see them. for just about everything else, we really only need a).
Comment #10
catchComment #11
Dries CreditAttribution: Dries commentedThis looks good to me too. Committed to 7.x and 8.x.
Comment #12
bfroehle CreditAttribution: bfroehle commentedUntagging since it's been committed to 7.x