CVS edit link for vgarvardt

I created a 'PHP code' plugin for Context 3. Module maintainers refused to bundle this plugin with Context module and suggested to provide this plugin in a custom module.

I created a module that includes Context plugin.

CommentFileSizeAuthor
#1 context_php.zip1.66 KBvgarvardt

Comments

vgarvardt’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new1.66 KB

Here is my module for review

avpaderno’s picture

Status: Needs review » Needs work

Hello, and thank you for applying for a CVS account. Some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

avpaderno’s picture

Issue tags: +Module review

I am adding the issue tags.

vgarvardt’s picture

Sorry for missed description.

Currently Context 3 bundled with the following condition plugins:
- Menu - checks active menu trail
- Node type - add/edit/view node of the selected content types
- Taxonomy - viewing node with the selected terms
- Path - page path
- Sitewide context - across the entire site
- User role - current user has one of the selected roles
- Views - displaying the page of one of the selected views

This set of conditions covers most of user requirements, but some useful conditions are not bundled. E.g. view user profile page, or condition negative value - you can set path condition to <front>, but can not set to all, but <front>.

'PHP code' plugin provides additional condition plugin for context module that allows user (who has access to context administer pages) to add conditions with PHP code that returns boolean value. This is the most flexible (yet complex) way to implement any condition - this plugin is some sort of analogue for PHP filter Drupal core module or PHP condition for Rules module.

avpaderno’s picture

Status: Needs work » Needs review

Thanks for the expanded description.

vgarvardt’s picture

One of users created a project from my module. What should I do?

zzolo’s picture

Wow, thats pretty messed up. This should be escalated. I will go on IRC and check it out.

avpaderno’s picture

As the module code has been posted in a comment outside the CVS applications queue, I think there is few that can be done.

zzolo’s picture

Well, I know there may not be any legal action, but as a community, something should be done, IMO. If nothing will be done by the drupal.org maintainers in some form to at least say that these actions are not cool, then I happy to be a vigilante.

Note that I started this thread to get more information: http://drupal.org/node/753802

greg.harvey’s picture

I don't see how this is an issue? The code is credited and has been from day one. Would've been nice of dixon_ to ask before creating a project, but it's all open source and copyright would remain with vgarvardt, for what it's worth.

I'm sure this can be resolved between dixon_ and vgarvardt.

@kiam, in light of his work, can vgarvardt be given a CVS account?

@vgarvardt when you get a CVS account, raise an issue with dixon_'s issue queue asking to be co-maintainer or maintainer, since you wrote the original code. If dixon_ is not really an a**hole (as I suspect) then he'll have no issue with your request. I'm sure he just jumped the gun and didn't realise he'd cause offence. =)

gerhard killesreiter’s picture

Status: Needs review » Reviewed & tested by the community

I have spoken to Dixon and he has no problem to hand the project over to vgarvardt.

Kiam: can you please give cvs access to vgarvardt and transfer the module to him? Please add dixon_ as co-maintainer.

vgarvardt: Please contact dixon_ about the future strategy WRT that module.

dixon_’s picture

Cross linking to my response for this: http://drupal.org/node/753802#comment-2770670

vgarvardt’s picture

vgarvardt: Please contact dixon_ about the future strategy WRT that module.

Sure, I will.

avpaderno’s picture

Status: Reviewed & tested by the community » Fixed

I have done as said by killes.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes