Update count of pre-existing nodereferences

@gmak, that sounds like a good idea when the number of nodes to update is relatively small. I'm concerned that a site with a large number of exisiting nodereferences would timeout if you did something like that. Using the batch api should allow any arbitrary number of node counts to be updated without worry of timeouts. Unless VBO already implements the batch api or does something similar, do you know if that is the case?

Ok, sounds like VBO is a good solution to this issue then. Thanks gmak and flying drupalist for your help. I've changed this to a documentation issue and I'll mark it fixed once I've updated the readme to include instructions for using VBO to update node counts.

It looks like the culprit is most likely a missing space. Notice the )AS. It should be ) AS. To confirm go to line 134 of nodereference_count.module and add a space in front of the AS. I think that should take care of it.

Ok, I see. It isn't selecting the right table. I'll have to look into that. If you have the devel module installed you can get some more info about what is going on by sticking a dsm() call in the foreach loop that is generating that SELECT. Probably dsm($db_info); would be most helpful. That variable is populated by a call to CCK, so for some reason it isn't getting the correct data.

Maybe it would be helpful if you map out the basics of the content types and the relationships you are using. It may be that I've made assumptions that aren't always true beyond my own basic requirements.

From the query it looks like you are trying to get an aggregate count from two separate nodereference fields. When you set up the nodereference count field what were the fields that you checked to have counted? It looks like one was 'field_event_reference'. What was the other?

Also does the error only occur with VBO or do you also see it when you save a node that is counted (or referencing)?

Thanks. That's super helpful. I'll see if I can replicate the issue.

Ok, I think I have a fix. It looks like it's just a stupid oversight on my part. I was pretty sure I had tested that case, but apparently not. I'll have it committed shortly, but if you want to test immediately, just nest the contents of the foreach loop at line 110 inside an "if ($referencing_field) {}". Basically the field array returns all the fields available, but the ones that should not be counted have a value of zero. It was including those and passing zero to the content_fields() function which returned some garbage and generated errors. It should just skip those now.

The latest dev release has the fix now.

Here is a proposed addition to the README with some VBO info. It could use some double checking by someone else to make sure I'm not forgetting something or missing something important by using a really simple test case.

Updating counts for pre-existing nodereferences
-----------------------------------------------
While the nodereference count fields will be updated when the node is saved or when the referencing node is saved, that isn't much help for pre-existing nodereferences to nodes created prior to the addition of a nodereference count field.  The Views Bulk Operations (VBO) module, http://drupal.org/project/views_bulk_operations, is the recommended solution .  Using VBO you can re-save all of the nodes that have a nodereference_count field.  That will update the count for each of those nodes.  The specifics will vary for each site, but the general instructions for doing this with VBO are as follows:

  - Install the Views and VBO modules if you do not already have them installed.
  - Go to /admin/build/views/add and create a new node view.
  - Create a new page display.
  - Change the style from Unformatted to Bulk Operations.
  - Select 'Use Batch API' under TO EXECUTE OPERATIONS.
  - Check 'Save post (node_save_action)' under SELECTED OPERATIONS.
  - Click 'Update default display'.
  - Add a path under Page Settings.
  - Add 'Node: Title' under Fields.
  - Add 'Node: Type' under Filters.  Be sure to select the node types that contain nodereference_count fields.
  - Save the view.
  - Visit the path that you set for the view.
  - Select all the nodes.
  - Click 'Save post'.  
  - Your nodereference_count fields should now be updated.
  - You are unlikely to need to use the view again, so feel free to delete it if you like.

Great. The change is committed. I think we can consider this issue fixed. If there aren't any other problems found in the next week or two I think it should be safe to make a 1.0 release.