berliner [berliner]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

Also I was wondering what principles are generally applied to a modules uninstall routine. Since this is a node module I initially thought it might be useful to delete all nodes of type sticky_notes on uninstall because they will not be of any value without the module being there.

Modules are not supposed to remove the node of the content type they define.

1. I would reformat the code contained in the installation file to avoid code lines with more than 80 characters.

2.   require_once drupal_get_path('module', 'node') . '/node.pages.inc';
   

   There is a Drupal function for that purpose.

3.     if (user_access('administer sticky notes')) {
         return t('The access to the default node forms for sticky notes has been disabled on the !preferences.', array('!preferences' => l(t('Settings page'), 'admin/settings/sticky_notes')));
       }
   

   l() should not be used together t(); see the documentation for t(), which report such code as wrong code.

4.   while ($row = db_fetch_object($result)) {
       $node = node_load($row->nid);
       $node->position_z = $zIndex++;
       $nodes[] = $node;
     }
   

   The code doesn't seem to filter out the unpublished nodes; this could be a security issue.

5.         'current_pattern' => urlencode($menu_item['path']),
           'current_path' => urlencode($menu_item['href']),
   

   The code should use the Drupal function.

6. There are some functions that don't have the correct name.

Remember to remove the file license.txt; there is a script that doesn't allow to commit a file with that name.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.