#228818: IE: Stylesheets ignored after 31 link/style tags landed for D7, but the solution uses the D7 render system which isn't available in D6. We can roll a patch to use STYLE tags when aggregation is disabled, but without the render API, it might be hard to make this behavior overridable by modules/themes that don't want it. What should we do?

Comments

effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia commented

Given that contrib solutions like http://drupal.org/project/ie_css_optimizer exist, my own opinion is for this to be marked "won't fix", but this is for the community to decide.

hass’s picture

hass CreditAttribution: hass commented

+

mcrittenden’s picture

mcrittenden CreditAttribution: mcrittenden commented

Sub. I'd also say this is a won't fix, since I wouldn't say it's more of a new feature than a bug. That said, I'd really like to see it get in, so keeping as active in case someone else wants to chime in.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Active » Closed (won't fix)

Confirming the won't fix. Backporting the solution of #228818: IE: Stylesheets ignored after 31 link/style tags is way to big a change for Drupal 6.

donquixote’s picture

donquixote CreditAttribution: donquixote commented

I was not there when the feature freeze policy was decided, but I understand that we have to avoid anything that could break existing sites.

A quite safe D6 solution would be to introduce an alter hook in drupal_get_css(), where a contrib module could specify a handler. One single handler. If no module implements that hook, everything will remain as it is.
Right now modules (such as unlimited_css) have to do this via hook_preprocess_page, which can fail if more than one module wants to alter the stylesheets.

The problems I can think of would be (i) rare nameclashes and (ii) modules that implement this hook would be worthless for D7 (who cares), and (iii) it does not solve the problem, unless you download an additional module, (iv) it could still be at odds with the feature freeze policy. Don't ask me.

At least, this could make it possible for distros like OpenAtrium to ship with a solid (more than existing ones) contrib solution for the 31 stylesheet problem.

ginc’s picture

ginc CreditAttribution: ginc commented
Title: Backport fix to IE 31 CSS file limit to D6? » Warn admin when IE 31 CSS file limit exceeds on D6
Status: Closed (won't fix) » Active

This is an important issue that can not be ignored. it can take days to figure out.

The problem isn't that there is no solution, the real problem is that it is very difficult to find what causes the problem:
http://support.microsoft.com/kb/262161

If we can't back port it, then at least we have to create a warning on admin pages and guide the admin to enable css optimization on performance settings.

hass’s picture

hass CreditAttribution: hass commented
Status: Active » Closed (won't fix)