CVS edit link for theunraveler

I have written a small but useful module that extends the Views module and would like to release it on drupal.org. It allows you to limit the number of rows under each group when using the "grouping field" in Views.

I have reviewed the CVS documentation, and am prepared to maintain this module and all future releases responsibly.

CommentFileSizeAuthor
#1 views_limit_grouping.tar_.gz2.11 KBtheunraveler

Comments

theunraveler’s picture

theunraveler commented
StatusFileSize
new views_limit_grouping.tar_.gz2.11 KB

Here's the module. I'm not sure about the module name yet; I may change it.

theunraveler’s picture

theunraveler commented
Status: Postponed (maintainer needs more info) » Needs review

Changing to needs review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code.

As per http://drupal.org/cvs-application/requirements, the motivation should be expanded, and include more details about the features implemented from the module (plus a comparison with the existing solutions).
Why didn't you open a feature report for the existing project?

theunraveler’s picture

theunraveler commented
Status: Needs work » Needs review

Thanks for reviewing my application. Here's the information you asked for:

Firstly, the code I submitted allows users of the Views module to limit the number of rows that are shown within each grouping when they are using the "grouping field" option. Currently, Views only allows you to limit the total number of rows displayed when using the grouping field option, which results in something like the following (if the number of of items displayed was set to 5).

Group 1
------------------
- Row 1
- Row 2
- Row 3

Group 2
------------------
- Row 1
- Row 2

As you can see, there is no way to only display only one row for each grouping field without making several different views. The code I submitted is an attempt to address that problem. As far as I could tell from somewhat extensive searching on d.org and Google, there are currently no other solutions to this problem.

The reason I did not submit it as a feature request/addition to the Views module was that this uses Views plugin architecture. Also, I am a bit concerned about Views bundling together a bunch of niche-use features. I think the constellation of features that Views could have are better served by auxiliary modules rather than having all of that stuff in Views core. Also, merlinofchaos seems really busy with Views 3.x and I didn't want to bug him :-).

Please let me know if there's anything else I can do.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed 
  form_error($element, ('<em>'. ($element['#title'] . '</em>' . t(' must be a numberic value.'))));

Use a t()-placeholder, instead of concatenating strings.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes