The attached zip contains a patch to the extractor module and a new placemaker.inc (to be included in the libraries directory) that adds Yahoo Placemaker support.

Comments

alex_b’s picture

Status: Active » Needs review
StatusFileSize
new3.01 KB

Rerolled after .zip. Reviewing now.

alex_b’s picture

StatusFileSize
new8.27 KB

Add missing patches to existing files. Disregard #1.

alex_b’s picture

StatusFileSize
new14.48 KB

- moved all feed integration functionality into extractor.feeds.inc - makes the two bridge classes simpler.
- Tweaked the call signature for extractor_extract() to make the required $library parameter more prominent.
- Minor code style fixes (removed double line breaks, cleaned up string concatenation, dots at end of comments)
- Added js to show placemaker specific form fields only if placemaker is selected.
- Linked to placemaker API.
- Updated README.txt (please review!)

Shouldn't language be optional? I have done the following modification:

if ($config['language'] != 'en_US') {

to

if (!empty($config['language']) && $config['language'] != 'en_US') {

Is that ok?

alex_b’s picture

I updated managingnews.make with this patch.

alex_b’s picture

StatusFileSize
new7.83 KB

'extractor_simple' instead of 'simple_extractor'.

alex_b’s picture

StatusFileSize
new14.51 KB

#5 is broken. Fixed.

alex_b’s picture

StatusFileSize
new14.5 KB

Remaining simple_extractor -> extractor_simple renaming.

rsoden’s picture

Status: Needs review » Fixed

Committed: http://drupal.org/cvs?commit=335578

Thanks Alex.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.