Closed (fixed)
Project:
Extractor
Version:
6.x-1.0-alpha1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Feb 2010 at 22:25 UTC
Updated:
15 Mar 2010 at 16:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
alex_b commentedRerolled after .zip. Reviewing now.
Comment #2
alex_b commentedAdd missing patches to existing files. Disregard #1.
Comment #3
alex_b commented- moved all feed integration functionality into extractor.feeds.inc - makes the two bridge classes simpler.
- Tweaked the call signature for extractor_extract() to make the required $library parameter more prominent.
- Minor code style fixes (removed double line breaks, cleaned up string concatenation, dots at end of comments)
- Added js to show placemaker specific form fields only if placemaker is selected.
- Linked to placemaker API.
- Updated README.txt (please review!)
Shouldn't language be optional? I have done the following modification:
to
Is that ok?
Comment #4
alex_b commentedI updated managingnews.make with this patch.
Comment #5
alex_b commented'extractor_simple' instead of 'simple_extractor'.
Comment #6
alex_b commented#5 is broken. Fixed.
Comment #7
alex_b commentedRemaining simple_extractor -> extractor_simple renaming.
Comment #8
rsoden commentedCommitted: http://drupal.org/cvs?commit=335578
Thanks Alex.