Invalid header count for empty message in theme_table(). [#722978]

Comment	File	Size	Author
#9	722978-9.patch	2.4 KB	duellj
#7	theme-invalid-empty-column-count-4.patch	913 bytes	alan d.
#5	theme.inc-3.patch	885 bytes	alan d.
#3	theme-2.inc_.patch	911 bytes	alan d.
	theme.inc_.patch	913 bytes	alan d.

Comment #1

alan d. commented 23 February 2010 at 11:46

Sorry, steps to reproduce. Simply have a look at a empty vocab listing in "admin/structure/taxonomy".

<table class="sticky-enabled" id="taxonomy">
 <tbody><tr><th>Vocabulary name</th><th colspan="3">Operations</th></tr>
</tbody><tbody>
 <tr class="odd"><td class="empty message" colspan="2">No vocabularies available. <a href="/admin/structure/taxonomy/add">Add vocabulary</a>.</td> </tr>
</tbody>
</table>

Log in or register to post comments

Comment #2

23 February 2010 at 12:00

Status:

Needs review

» Needs work

The last submitted patch, theme.inc_.patch, failed testing.

Log in or register to post comments

Comment #3

alan d. commented 23 February 2010 at 12:22

Status:

Needs work

» Needs review

Status	File	Size
new	theme-2.inc_.patch	911 bytes

Lets see if ConText can save the correct line endings...

Log in or register to post comments

Comment #4

23 February 2010 at 12:40

Status:

Needs review

» Needs work

The last submitted patch, theme-2.inc_.patch, failed testing.

Log in or register to post comments

Comment #5

alan d. commented 23 February 2010 at 12:59

Status:

Needs work

» Needs review

Status	File	Size
new	theme.inc-3.patch	885 bytes

OK, ConText convert filter run a couple times...

Log in or register to post comments

Comment #6

23 February 2010 at 13:10

Status:

Needs review

» Needs work

The last submitted patch, theme.inc-3.patch, failed testing.

Log in or register to post comments

Comment #7

alan d. commented 23 February 2010 at 13:32

Status:

Needs work

» Needs review

Status	File	Size
new	theme-invalid-empty-column-count-4.patch	913 bytes

Duh. Wrong context.

Log in or register to post comments

Comment #8

effulgentsia commented 23 February 2010 at 21:40

Status:	Needs review	» Needs work
Issue tags:		+Needs tests

Related but different: #720202: theme_table doesn't use thead with empty cells. Please add a test.

Log in or register to post comments

Comment #9

duellj commented 22 April 2010 at 20:14

Status:

Needs work

» Needs review

Status	File	Size
new	722978-9.patch	2.4 KB

Fixed spelling error in last patch, and also updated testThemeTableWithEmptyMessage to include a check for correct colspan in empty message when header has a colspan.