CVS edit link for danph

I wish to contribute a module which extends the functionality of Migrate by providing helpers to import data into Organic Groups.

The following are provided:

* Group-User (member) relationships (many to many)
* Extend nodes that are designated as an Organic Group type by providing OG specific attributes.
* Extend nodes that are designated as Organic Group post types by adding an audience field.

CommentFileSizeAuthor
#6 dani-Migrate-OG-b3e4729.tar_.gz4.49 KBdpi
#1 migrate_og.zip5.24 KBdpi

Comments

dpi’s picture

dpi
Location Perth, Australia
commented
Issue tags: -Module review
StatusFileSize
new migrate_og.zip5.24 KB

Attached is the module.

To test, you must:

* Install Migrate (Dependencies: Table Wizard etc.)
* Install Organic Groups
* Make changes to Migrate module outlined in README (hopefully I can contribute these changes as a patch to Migrate in the near future. - Patch submitted to Migrate.)

Additional incomplete functionality which are tertiary objectives for this module are outlined in TODO.txt

View README in a web browser for some tips.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs review
Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code.

Did you verify there are not other modules with a similar purpose?

dpi’s picture

dpi
Location Perth, Australia
commented

@kiam, As far as I can tell there are no modules for which I am duplicating code. Both Google and the Issue queue's for the respective modules do not have any complete functionality like this.

This issue: #562300: Support for Organic Groups? discusses such functionality, but does not include any code.

I have chosen to make this module separate as opposed to a patch to Migrate Extras because I am doing some non Migrate-standard methods of migrating data (contains destinations to Relationships, >1 key). I will be creating a patch for Migrate to get the maintainer' approval.

I believe the code standard to be as close to the recommended Drupal standard.

dpi’s picture

dpi
Location Perth, Australia
commented
Status: Needs work » Needs review

A patch (#725462: Add $tblinfo to delete hook) has been submitted to Migrate to allow support for this module.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
Issue tags: +Module review 
  1.  db_query("UPDATE {%s}
            SET dest_group_nid='%d', dest_user_uid='%d'
            WHERE sourceid='%d'",
            $cset_info->maptable, $gid, $uid, $row->$sourcekey);

    Placeholders don't work for the table name, as field names, and table names are escaped differently. 

  2. // @TODO: See readme for critical information about what needs to be done here.

    Does that comment refer to cod that needs to be added to the module? The code should be almost complete, when proposed per a CVS application.

  3. The file README.txt is plain text; using HTML tags inside it doesn't make reading it easier.
dpi’s picture

dpi
Location Perth, Australia
commented
StatusFileSize
new migrate_og.tar.gz4.49 KB

The patch that Migrate OG depends on has been accepted into Migrate (#725462: Add $tblinfo to delete hook).

Changes mentioned above have been made to Migrate OG. The HTML edition of the text has been moved into Advanced Help and the regular README has been stripped of markup.

Please re-review.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Module review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes