This patch is phase 1 in a many-phased plan to help improve Drupal's administration system, making it easier to use. The longterm goals of this effort are to make it so that newer users can more easily figure out what it is Drupal can do for them, and to make site designers more comfortable with handing administrative tasks off to a novice site maintainer.

This patch replaces the 'admin' page which simply lists the watchdog log with a 2 column page which contains administrative items categorizes in a way that makes sense to me. I've taken the categories as applied from at least 4 different sources and organized them in a manner that seems logical to me. I suspect this organization may be tweaked here and there, but overall I think it is pretty decent.

The items and categorization are both provided via hook_admin_info, and are sorted by weight and title. The descriptions are the best I could come up with without spending hours and hours getting them just right. I am sure these could use some tweaking to properly describe what each item does.

The administration page comes with a block that has two options: The administrative theme, so that the admin page (and all other admin pages) can easily be kept in the default theme (this is a Good Thing, yes) and an 'expert mode' which really just turns off the description.

Future plans: There is a vague plan of making this page re-organizable by the administrator. At the moment I don't know how necessary that is but it may or may not happen depending on how much time and energy I or someone else is willing to put into it.

Javascript: Once we have a good jquery integration, I'd like to make the blocks collapsible so that they can be gotten out of the way. Alternatively, we can transform the blocks into tabs. I'd like to add tabs to the system settings page (also requires jquery) and I want to work over the admin/modules page.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

merlinofchaos’s picture

FileSize
33.88 KB

Gosh it'd help if I attached the patch, eh?

merlinofchaos’s picture

FileSize
38.26 KB

Addendum the first: This is based upon my work that stemmed from my my blog posts:

http://www.angrydonuts.com/another_attempt_at_administrativ

and

http://www.angrydonuts.com/administrative_addendum

Also, a screenshot is attached.

drewish’s picture

i haven't had a chance to play with this, but my only comment, based on the screen shots that you linked to, is that i'd prefer that modules in sub-directories be grouped together in the list rather than placed on their own tabs.

merlinofchaos’s picture

The modules page is not redone in this patch; only the 'admin' page.

merlinofchaos’s picture

FileSize
34.01 KB

Revised patch based on chx' commentary: Change in comments on theme functions and _sort functions return 0 when $left and $right are, in fact, equal.

chx’s picture

In overall, I like the patch. The devil is in the details. First of all, I'd like to see user_access calls removed and _menu_item_is_accessible used:

$q = $_GET['q'];
// a loop here..
$access = _menu_item_is_accessible(menu_set_active_item($path));
// after the loop
menu_set_active_item($q);

second, I am not sure I like the word 'block'.

And finallly, an alter hook is needed.

Dries’s picture

Looks good. I like. Here are some minor issues:

* Don't use tabs; eg in your CSS file changes.
* Rename 'config' to 'configuration'.
* Rename 'admin' to 'administer' or 'adminsitration'. Using abbreviations in user output is not professional.
* url should be URL
* blogapi should be BlogAPI
* Don't cap each word: 'General Site Configuration' -> 'General site configuration'.
* Some titles only use lower-case sentences.
* $block[description] is going to generate warnings. You have to write $block['description'] ...

Dries’s picture

I wonder if we need a different way to have the menu system interact with the "administration blocks". One of the fundamental usability guidelines is that link names match the title of the destination page. Thus, if you have a link called 'system logs', the destination page should be titled 'system logs' too. The menu system enforces this rule. The administration blocks violate this rule ...

I'm just thinking up loud here, but maybe it would be better if the administration blocks would correspond with the top-level menu items in the administration menu, and that the administration block items correspond with the second-level menu items.

The advantages would be:
* No need for an extra hook, less code, less run-time overhead.
* Menu items, link names and page titles always match -- this is enforced by the menu system.
* The administration page automatically maps onto the menu system. Usability is all about being able to create a 'mind map' of how things works. I think this enforced consistency would help people creating a good mind map.
* Shuffling the menu items around from the ?q=admin/menu item page will also affect your administration blocks. That is, people can redefine the administration blocks using the existing menu building interface.

merlinofchaos’s picture

Most of the comments I'll deal with tomorrow if I can, but the $block[description] in the code is correct, as it is in the midst of a heredoc which means it's effectively encapsulated in "" -- so $block['description'] will throw an error.

Dries’s picture

The more I think about it, the more I think #8 is the way to go. Is there any limiations of problems with #8 that you can think of? (Sure, it would require significant menu restructuring but that is cool. The final outcome is what matters.)

merlinofchaos’s picture

Okay, here are two reasons that I didn't like having the blocks map to menu items.

1) Being menu items, they have to have a destination. This destination, in the zadministration.module, was largely pointless. It feels quite superfluous.

2) By separating the administration page itself from the menu system, you can actually get a second administration hierarchy. While this sounded kind of bad to me at first, I actually kind of like it now. Why? For one, it makes for a much easier transition for existing users, who are very used to the current system (and some very vocal). These folk will accept some level of reorganization, but are highly resistant to the complete reorganization that menu module offered.

3) Using this system and an alter hook, it'll actually be much easier to create customized administration interfaces than with the menu system.

4) One of the biggest problems I had in zadministration module was adding links to the menu system, especially if you have external links. Amazon's ideal had links back to drupal.org for stuff, and I actually think this is a great idea. A direct link to the modules page on drupal.org. A direct link to the handbook. These are not really possible with the existing menu system.

5) The create content section needs to exist in multiple places. I almost always move my create content links out from under create content and put them in menus that are contextually appropriate. In today's menu system, you can't have links in multiple places. With this administration system, you can put some of your admin links in contextually appropriate places within your site without messing up the menu system organization.

6) The menu system, by itself, doesn't contain enough data to construct these pages, especially the blocks. I think we were able to cram a description into the menu system, by re-using the field that's supposed to go in the tooltip over the link. [Reminder to self: Need to make sure that goes into the expert mode on next pass]. But it certainly does not have enough information in it to construct the blocks; we'd have to add some.

7) The existing system lets us put in information from outside the menu system as well, like the little settings block, and the way the create content block is constructed is a nice example.

While writing this, I had the same reservation you have about how this kind of duplicates the menu system's functionality, and does add a fair bit of code in order to accomplish it. My experience with previous efforts though, felt like the menu system was very limited.

I do agree with the naming issues, and on the next pass (if we agree that a next pass should be done) I'll go through and straighten up naming -- either to rename the pages or rename the links.

moshe weitzman’s picture

my gut feeling is that the menu system is excessively rigid for the nice /admin page we want. the menu system is too much of an engineer's solution. we need a user experience frame of mind here. i'll try to articulate this a bit better if needed.

Dries’s picture

My gut feeling still tells me that improving/extending the menu system is the best way forward, but I'll let other people review this patch too.

(Improving or extending the menu system is perfectly OK and actually needed.)

scroogie’s picture

I remember a module which did the same thing with additional options and icons. Was it abandoned?

Morbus Iff’s picture

merlin: permit typical "you didn't even try it, did you?" ignorance, but some screenshots I saw on your pissed-off-confectionry site suggested an overabundance of tabs: admin/settings appeared to have everything tab'd, which makes it nearly unusable on smaller resolutions. Nor do I think that have more than 5 tabs is a good idea: there's tons of regular OS application design that lambasts applications with lots of tabs. Anyways, you can heartily ignore this comment: I've not tested the patch, going on shoddy recollection of screenshots I saw on your site, and am generally being unhelpful. Excelsior!

merlinofchaos’s picture

Morbus: See comment #4. This is only the 'admin' page.

merlinofchaos’s picture

Here, in fact, let me make this abundantly clear:

---------> There Are No Tabs In This Patch <----------

The next person to complain about them will get the same message, but with expletives added for emphasis.

merlinofchaos’s picture

Ack, I always forget that > will get eaten, so a sentence was lost:

The next person to complain about the tabs will get the same message as above, but with expletives added for emphasis.

patrickharris’s picture

Title: Patch to give Drupal an overall administration page » re Tabs

Tabs are great - their useability only suffers when the tabs change position when highlighted.

Tobias Maier’s picture

Title: re Tabs » Patch to give Drupal an overall administration page

subscribing...

Dries’s picture

FileSize
4.75 KB

Here is a patch that accomplishes the same by leveraging the existing menu system, as per my comment above.

Note that this is a 'prototype patch'; it's quick and dirty in terms of CSS and it doesn't create useful blocks! The sole purpose of this patch is to demonstrate the underlying approach.

  1. It is required that we redo the layout/structure of the administration pages so that they match those in Earl's screenshot. This has been planned anyway. In the mean time, this patch does a good job highlighting the poor organization of the current administration menu. ;-)
  2. If someone wants to cool up the look and feel of the blocks, please do. In the mean time, I hope you can ignore the uglyness of the UI and the poor navigation structure. The goal is to compare it with Earl's approach and, hopefully, to debunk some of the myths surrounding the menu system.

Advantages:

  1. No changes have been made to the menu system. No new hooks have been introduced.
  2. Page titles automatically match menu links. This is a usability requirement.
  3. Breadcrumb paths make sense. This is a usability requirement.
  4. The navigation menu in the sidebar is automatically in sync with the main administration page. This is a usability requirement. (The speed by which people can learn to operate a system, depends on how easy/fast it is to build a mind map of the system.)
  5. Menu descriptions are used on the main administration page, as well as for link attributes. Less strings to translate, no duplication of information, and ultimately, less code.
  6. You can configure the main administration page using the existing menu administration. Earl's system does not allow custom configurations, as far as I can tell.

Disadvantages:

  1. It's not (yet) possible to add 'information blocks' with no links (eg. with some basic statistics or important watchdog messages).
Dries’s picture

FileSize
53.35 KB

Here is a screenshot. Yes, it looks ugly. See explanation in the comment above. After (i) improving the CSS, (ii) adding descriptions to the menu items, and (iii) restructering the administration menu it could look exactly like Earl's screenshots. :-)

(You have to flush your cache-table if you want to play with this patch.)

merlinofchaos’s picture

Dries:

1) Ok, so how do we do the info blocks? I really like the settings (being able to select the admin theme is, IMO, an important usability option. MOST themes I plug into my test site I eventually turn off because the admin interface isn't usable with them; forcing the admin interface into bluemarine and letting the admin select that behavior is a major improvement) and I think it's important that the admin settings be as close to the top as possible, or they'll disappear.

2) Likewise, being able to create blocks that put in important statistics is something I was really trying for. Perhaps we could merge thet wo approaches? We add a hook, but this hook asks for content for the menu blocks, rather than menu items?

3) Do we lose the automatic admin/settings/MODULE if that turns out not to be the appropriate place for that module's settings? (Note that I put very little that deep in my setup). We'll need some way to keep that automatic page yet somehow have it be in an almost arbitrary location in the menu system.

4) Each of the links that leads to a block needs to have content of some sort now. What do we put there? Hm. Well, maybe if we add DHTML to Drupal's menu system we could avoid having those pages have content, but then disabling javascript means those menus are permanently expanded. (Which, IMO, is probably fine, but I can see some people objecting to that). And we'd have to figure out how to retool the menu system for that. But for example, 'settings' is a block in just the current design, but also a very important link on its own.

merlinofchaos’s picture

Oh, I forgot one:

5) Some people want icons. While my patch didn't inherently include icons, there was an easy path to add them. Can this do the same thing? All there needs to be is a place to add the icon path in the menu structure. If that's true, that plus re-theming could add the icons.

Dries’s picture

Thanks for your comments/review.

The current patch doesn't allow for generic blocks (eg. information blocks, statistics blocks). Your concerns expressed in (1) and (2) can be solved by adding an extra hook. A hook that has nothing to do with the menu system; it would probably look like a simplified version of your proposed hook, or like the regular block-hook. Or maybe these can be regular blocks (in combination with a new blog region or something)?

Placing blocks of content on pages looks like an important feature of a content management system. It wouldn't hurt if there was a generic mechanism (probably the block system or something like the frontpage module) that allows people to put blocks of content on a page. There might not be a good short term solution (other than a quick hook), but hopefully, we can come up with a generic solution at some point. It's core functionality, don't you think? And it shouldn't be limited to the main administration page. One day, for example, I'd love to do something more fancy with drupal.org's and buytaert.net's front page. ;)

As for (3), not sure I understood what you were saying but I didn't touch the settings pages in this patch. I did touch the settings pages in another patch. It does attempt to remove the automatic settings pages and splits up the main settings page in sub-pages. That patch removes 2 special cases, and fixes some usability concerns while doing so. Using the regular callback system for settings pages makes sense; there is no reason to treat them as being special, nor should we restrict administrators from being able to shuffle settings pages around (currently, the settings pages are unknown to the menu system).

I don't have a solution for icons (item 5). However, I could add support for icons with a 2-line patch to the menu system.

I (obviously) prefer the approach taken in my patch but like to know what you and the others think about this? I'd like to move this forward; it's only 1.5 months until the code freeze, and committing 3 big patches in the last week isn't an option.

If you want to help (please) or if you want to toy with it (please), here is what you can do:

  1. Improve the CSS: make it more sexy.
  2. Add descriptions to the menu items -- they will also be used as title-attributes in the regular navigation menu.
  3. Change the paths in the menu_ hooks of the modules. We want to model things after your proposed layout.
merlinofchaos’s picture

For 3) the *nice* thing about hook_settings() is that the module doesn't have to have any code to store its global settings. That's both good and bad (over-use of this does make the $conf variable very large).

Are you saying this'll require modules to handle their own settings? Or perhaps there is some nice way that we can run things through the menu system to get to those settings.

Let me ponder the block idea. Maybe just putting blocks on the into the page is all we really need, and then we can have administrative settings as a block, and a statistics block (for another patch; that one alone needs a lot of thought).

I will have free time again this weekend to do some work on this, but if anybody else wants to do some of the grunt work of menu re-arranging, I'm ok with that too. But I also want to get this done and in, as it's just a step toward a lot of other things that also need to be done.

Dries’s picture

We should probably move the discussion around (3) to that other thread. That said, Drupal has a helper function to create settings pages: see system_settings_form(). It's a trivial change. In fact, many of the core's modules stopped using the _settings hook already. Just grep for 'system_settings_form' and see. I'll try to convert some of the remaining modules tomorrow. I'll post an update to that other thread ...

Dries’s picture

By the way, changing the paths of pages should be fairly straightforward. If the callbacks use the automatic argument-feature (and almost all callback functions in core do) rather than hardcoded arg(x)s function calls, it should be fairly easy to do.

If you encounter callbacks that use arg(), we might want to mark them. Using arg() in a callback is a bug because it does not allow the page to be moved by the user (through the menu module). The menu module will let you change the path, and when you do so, the page will be broken.

In short: callbacks should not use arg() and when they do, changing their position in the menu tree should be easy.

chx’s picture

adding more chaff to menu is a very bad idea given that's always loaded and it's quite big.

Dries’s picture

It is a bad idea because there might be a performance cost. It is a good idea because it improves usability. So depending on what hat you are wearing, it can be good or bad.

It begs the question: should the user /suffer/ because the internal implementation of a building block doesn't scale? My answer is that we need to fix or improve the building block's implementation.

Moreover, we did NOT touch the menu system. We're just using the provided functionality/APIs. Frankly, it is the menu system's (internal) problem. If it doesn't scale, it is not this patch's fault. Contributed modules would be able to do exactly the same. That doesn't mean we don't have to be careful, of course.

Also, we haven't evaluated the performance cost yet, so maybe it is not noticable. Frankly, we can't tell. However, we could do a simple experiment to figure that out. We shouldn't reject this idea without factual data to backup some claims.

beginner’s picture

commenting on patch #21.
I don't get anything that looks like the screenshot in #22, but that's a detail.

I see a huge problem by the approach which I believe is being used here (use $items in hook_menu() to automatically create the entry admin page).
We now have direct links to some pages which are secondary tabs for the admin of some modules (e.g. you can directly access ?q=admin/themes/settings without going through /?q=admin/themes which may be convenient), but it has some serious unwanted side effect: we have a direct link to, e.g. ?q=admin/block/delete or q=admin/block/configure without having the block id being defined, which is very confusing.

For such an approach to work, we need to add a key or two to the admin/ items returned by hook_menu(), like:

$items[] = array('path' => 'admin/mymodule', 'title' => t('Mymodule Admin'), 
       'callback' => 'mymodule_admin', 
       'access' => user_access('administer my module'), 
       'type' => MENU_NORMAL_ITEM,
       'admin_listing' => TRUE,
       'admin_block_category' => 'Content management block',
); 
beginner’s picture

Status: Needs review » Needs work

:)

merlinofchaos’s picture

Hmm. With the settings changes this patch doesn't apply cleanly anymore. Dries, can you freshen?

Dries’s picture

FileSize
3.7 KB

Resynced with CVS HEAD.

merlinofchaos’s picture

FileSize
6.5 KB

First pass -- integrated my theme and CSS stuff. Next up: re-organization.

merlinofchaos’s picture

FileSize
20.22 KB

Ok, here's my work so far. Since I don't foresee any free time until next week, I'm putting this up here so others can continue this if they want.

1) I got started on a bit of the re-organization, but generally only in system.module.
2) I moved admin/modules into admin/settings/modules which is actually an unfortunately fairly sweeping change, so we're going to probably need to do a global search and replace to get all the references. I'm not sure that's actually the right place for it; it could be that 'modules' is its own block and it could provide status on enabled modules, with links to their settings pages. So a lot of pages might move from admin/settings/modulename to admin/modules/modulename or something very similar to that.
3) I included a method to get stuff that isn't just menu items into the blocks. Not sure if it's the Right Way to do it but it seems consistent with Drupals methodology. Curious what people like Steven will think.

merlinofchaos’s picture

FileSize
20.23 KB

Oops. Fixed the admin page settings.

merlinofchaos’s picture

Status: Needs work » Needs review
FileSize
194.59 KB

Here we go. This one completely re-organizes the menu. The patch is fairly large, due to the fact that a couple of very imporant paths were changed, which touches a great deal of the files.

I expect there will be some general disagreement over how the menu should be organized.

I expect there will be reason to tweak a lot of the nooks and crannies in this system.

These are both okay; what I would like to do is review this for:
1) General acceptableness. If the techniques and overall features are good, that's a major thing.
2) Bugs. The patch that goes in should actually, like, not break things.

If we can get past those, I think we should commit the patch, and then open issues against the little nitpicks here and there.

On my next followup I'll attach a screenshot.

merlinofchaos’s picture

FileSize
34.35 KB

Here's a partial screenshot. The actual page is a little long due to all the text. I suspect this alone will create some conflict amongst people.

I can give people access to my test site to do clicking around and such. Contact me on the IRC for that. My test site is only good, really for usability testing. People who want to bug test should try to apply this to their own test site.

merlinofchaos’s picture

Oh, remaining TODO items while people test this out:

1) Write up a guide for module developers on how to apply their admin menus to this system.
2) create content currently pulls its info from hook_help -- I tried, momentarily, to work with that but it's actually kind of difficult. As a future consideration I would like to redo node/add/* to not use hook_help and use the menu['description'] field, and require all node modules to implement node/add/nodetype -- this really should be required anyway for access control reasons.

eaton’s picture

I've installed it on a clean HEAD and it's working perfectly. I can't stress how much of an improvement it is for busy sites; the ability to switch to 'streamlined' mode and the ability to specify a separate administration theme is a huge benefit, too.

The use of the menu system to define the groupings makes good sense. I still need to dig around a bit more, but so far it gets a bit +1 from me. Three cheers for 4.8/5.0.

rkerr’s picture

I'm liking merlin's approach to this. With the old menu items, I think it was exposing too much of the mechanics of things instead of presenting logical options to make things easier for an administrator. Based on the latest screenshot, it looks much more clear. (Although some of the new menu titles are maybe a little verbose but that is a minor detail at this point).

chx’s picture

I like this patch and if it goes in, then I think it'll be fairly trivial to change menu system to not cache descriptions as they are rarely needed, instead we can have a menu_get_description($path); which rebuilds the menu in memory and provides descriptions.

Dries’s picture

(To others: when you test this patch, make sure to enable many modules.)

Here is a first review:

  • I like it. Good job!
  • I think that the 'administration settings' block that lets you change the administration theme is way to prominent. I like the functionality, but I don't see why it should be on the main administration page. It's a setting like any other setting and shouldn't be a special case, IMO. Secondly, by putting the setting on the main administration page, it suggests that it is a per-user setting (like the watchdog filter). It looks like a global setting and that is another reason not to put it on the main administration page.
  • 'System Default' should be 'System default'.
  • 'Admin theme' should be 'Administration theme'.
  • 'blog APIs' is listed under 'module management' -- looks like a bug/miscategorization?
  • Right now, the 'site configuration' block is at the top, and the 'site building' block is near the bottom. It would be more convenient if the frequently accessed blocks where near the top. I'd use the 'site building' block an aweful lot.
  • The 'status page' Steven is working on could probably become part of the 'logs' block.

Good stuff, Earl!

hunmonk’s picture

patch works as advertised, and is a huge improvement to the usability of the admin section. +1.

one thing i did notice was that when visiting /admin/block, it simply dropped me back at /admin. i see that /admin/block isn't the path to get to the block admin page anymore, but we should be presenting a drupal not found page for any /admin sub-paths that are not valid...

merlinofchaos’s picture

Dries;

I think that the 'administration settings' block that lets you change
the administration theme is way to prominent. I like the functionality,
but I don't see why it should be on the main administration page. It's
a setting like any other setting and shouldn't be a special case, IMO. Secondly, by putting the setting on the main administration page, it
suggests that it is a per-user setting (like the watchdog filter). It
looks like a global setting and that is another reason not to put it on
the main administration page.

I'm a little torn on that block. I can definitely see an argument for making it just a link in the settings, but I also think the expert mode ability and theme ability changes should be prominent on that page; for one, switching into expert mode is an instant gratification thing. But maybe that shouldn't be a block, maybe it should be a *link* on the top of the dashboard.

I can see a real argument for why this should be a per user setting, especially 'expert mode'. or perhaps a global setting with a per-user override.

How about this:

  • 'expert' mode becomes a per-user setting (stored in the user data field, rather than a setting).
  • A link on the top of the page will offer to 'Switch to expert mode', 'Switch to verbose mode' (Or some better wording?)
  • The rest of it remains a link available at the top of the settings block.

Capitalization and abbreviation fixes (so habitual. 'admin' is practically a word in my vocabulary) applied and will turn up in the next patch.

'blog APIs' is listed under 'module management' -- looks like a
bug/miscategorization?

Yea, when I moved the blog api menu item into modules I thought a couple of other items would follow it, but nothing else volunteered to move (yes, I personify this stuff when I'm deciding where to put it). So it does seem out of place. However, if you have several contrib modules active and they have admin items, that block will be a little less barren. That said, it may still not be the right place. It can move back to the settings block.

Right now, the 'site configuration' block is at the top, and the
'site building' block is near the bottom. It would be more convenient
if the frequently accessed blocks where near the top. I'd use the 'site
building' block an awful lot.

No problems here. I think a future patch will need to address the fact that people will need to re-organize this stuff, but I don't want to do that now. Before I actually move blocks around, I'd like to hear some discussion, because my feeling is that if 5 different people chime in, there will be 5 different opinions on where what block should be. Maybe I'm wrong. Hopefully I'm wrong!

one thing i did notice was that when visiting /admin/block, it simply
dropped me back at /admin. i see that /admin/block isn't the path to
get to the block admin page anymore, but we should be presenting a
drupal not found page for any /admin sub-paths that are not valid

Yes. Additionally, I think legacy.module should include some drupal_gotos for some of the old paths (admin/block and admin/menu come to mind). I'll put at least the former into the next patch, and probably the latter too.

chx: That would definitely be a good idea.

moshe weitzman’s picture

@hunmonk - the behavior you request, a 404 instead of /admin page for admin/block is a longtime feature/bug of the menu system, and is out of scope for this issue IMO.

merlinofchaos’s picture

moshe: I think it's perfectly fine; the admin page can check to see if it received an argument. Since it expects none, if there is one, they must've meant something else, and we can 404. While slightly hackish, this will reduce confusion, which is IMO a good thing.

moshe weitzman’s picture

@merlinofchaos - that sounds fine. if you make this behavior part of menu declaration, then all modules can benefit. just add an item for hook_menu items like: 'accept arguments' => FALSE. the menu system can then issue 404 if it chooses this path and an arg is present.

the huge benefit of this is that we can deny arguments for the node/ path and give 404 instead of the home page!

merlinofchaos’s picture

FileSize
196.21 KB

Moshe: Great idea. A bit out of scope for this patch, so I'm going to do the following:

1) Leave the 404 thing I added in for now.
2) Create a new issue, and once that's in a 404 handler can be removed from this admin page.

Speaking of, here is the most updated version of this patch. It includes most of what was talked about above, *except* actual blocks moving around. It includes a 'toggle' for the expert mode which appears above the menus, and I like this very much. With that there, the administration settings block is no longer necessary and it has moved to its own page.

It also contains a couple of text fixes and some doxy style headers that should've been there in the first place.

whatistocome’s picture

just subscribing...

nedjo’s picture

Status: Needs review » Needs work

Very nice. The patch applies cleanly. On my basic testing I don't find any bugs. I'll continue to test and report any problems.

Some comments:

  • The implementation through the menu system is clean and well thought out.
  • The division by category of task makes sense to me.
  • The expert mode is useful. I'd wondered if we should consider doing this through js, since with some tweaks the display could be changed through a simple css class toggle, but we'd also need an AJAX post to set the variable and that seems overkill.
  • In the CSS, tabs should be replaced with spaces for indentation.
  • A couple of the sections look sparse with only one item (Module management and Logs) but I think that's okay and we may add to them.
  • Because it doesn't have a section, categories doesn't appear on the main admin page. Should it get a section? or possibly go under one of the existing ones, e.g., Content management?
  • The item "manage users" on the main admin page doesn't fit well gramatically with the rest, since it's action focused rather than descriptive. Simply "users" might be better.
  • The 'description' text in the sections (top menu items) could be more parallel. Some are full sentences and others not; one begins with a verb, others don't. There is a fair bit of repetition of the phrase "to help you". I suggest either (a) begin all with "Tools for...", e.g., "Tools for managing your site's content" or (b) skip the tools and begin with verbs, e.g., "Manage your site's content".
  • It would be useful to be able to associate icons with the menu items (in a future patch). I've roughed in a patch that would enable this by adding a custom class attribute for menu items, http://drupal.org/node/42493.

Altogether, a great improvement and IMO needing only minor tweaks before being RTBC.

merlinofchaos’s picture

Status: Needs work » Needs review
FileSize
195.88 KB

# The expert mode is useful. I'd wondered if we should consider doing this through js, since with some tweaks the display could be changed through a simple css class toggle, but we'd also need an AJAX post to set the variable and that seems overkill.

Yea, I agree that it's overkill.

# In the CSS, tabs should be replaced with spaces for indentation.

Probably carried over from numerous cut & pastes and I can never actually see the difference. Nice catch, corrected.

# A couple of the sections look sparse with only one item (Module management and Logs) but I think that's okay and we may add to them.

I think so too; Maybe logs should be 'Logs and Status' and more clearly be the place you go to just get information without actually necessarily doing stuff.

# Because it doesn't have a section, categories doesn't appear on the main admin page. Should it get a section? or possibly go under one of the existing ones, e.g., Content management?

Hmm. I show categories under 'content'. It's right there beneath 'books' or is there something else I'm missing?

# The item "manage users" on the main admin page doesn't fit well gramatically with the rest, since it's action focused rather than descriptive. Simply "users" might be better.

Yea, I think I agree. I was looking for it earlier and manage users wasn't leaping out to me as the right link.

# The 'description' text in the sections (top menu items) could be more parallel. Some are full sentences and others not; one begins with a verb, others don't. There is a fair bit of repetition of the phrase "to help you". I suggest either (a) begin all with "Tools for...", e.g., "Tools for managing your site's content" or (b) skip the tools and begin with verbs, e.g., "Manage your site's content".

One area I knew would need some work, my ability to be consistent here is somewhat twitchy. I like the active version better just reading them, and am going with that for this round.

# It would be useful to be able to associate icons with the menu items (in a future patch). I've roughed in a patch that would enable this by adding a custom class attribute for menu items,

I think that patch is ideal for this kind of thing; it'd make icons trivial and completely based upon the administrative theme, which is exactly where to put them.

Updated patch attached! I moved a couple of blocks around based upon Dries' comments earlier and some aesthetics as things have shifted.

Thank you very much for the comments!

(I'm not going to set it myself but I think we're very close to RTBC; probably the next person with some authority who agrees with me should set it)

Dries’s picture

FileSize
295.82 KB

Here is a full-length screenshot for those who want to review the categorization and/or the help texts without installing the patch.

Morbus Iff’s picture

Dries: useful, thanks.

  • Manage your site's content -> too repetitious with the preceding header. Couldn't think of a better one though: "administer your site's data"? Also note that there's no period at the end of this sentence.
  • How come the menus in the sidebar block aren't alphabetical?
  • Books description doesn't end in a period.
  • Comments -> The moderation queue isn't in core, no?
  • Also, I prefer the more European method of list punctuation, which means that there's a comma after every item in the list ("comment moderation queue[,] and edit comments.").
  • Content types -> "comment and publication status".
  • Content types -> no period, and don't use "and much more". No marketing.
  • File uploads -> "what how".
  • Forums -> "Control forums and their hierarchy and ...".
  • Forums -> why are the settings under this menu item?
  • Posts -> "site's" not "system". Use the same words.
  • Posts -> European commas: "edit[,] and delete".
  • Post Settings -> In reading over this organization, it seems odd that "Post Settings" and "Content Types" are two different screens.
  • Don't use the term RSS. Use the term "Syndicated" or "Syndication".
  • Don't use "RSS" or "Syndicated" "aggregator". Just use "Aggregator.
  • Aggregator -> Remove "outside" and "makes available", s/polls/retrieves this data/".
  • RSS feeds -> Syndicated, and "your site provides" not "Drupal provides".
  • Search posts -> No period; can't you search users as well?
  • European commas - "activate, deactivate[,] and administer modules.
  • Blog APIs -> "which content types and engines external blog clients can use."
  • Access control -> no period.
  • Access rules -> European commas.
  • Roles -> European commas.
  • Search users -> "keyword" suggests it looks through profiles. Change to "by name".
  • Speaking of profiles, I don't see it anywhere on here.
  • Oh. Heh. Remove "user ". We already know it's users, cos we're under the Users block.
  • User profiles -> "create customizable fields for your users", perhaps? This one needs work.
  • Users -> European commas.
  • User settings -> "Configure default" here, "Manage the default" elsewhere. Pick one. ("Configure" is better.)
  • User settings -> European commas.
  • User settings -> I think we use "e-mail". Doublecheck and standardize.
  • User settings -> "user pictures."; remove "configuration". We expect that.

Hopefully next column later.

rstamm’s picture

Good job. I think this would improve the usability a lot.

But I prefer "site management" or "system management" instead of "module management".

eaton’s picture

"Site" and "System" are far too general, though. Almost any portion of the admin screen could go under that heading. If modules need better-delineated sections for their own options, they can create their own menu trees and will automatically be given panels on this screen.

merlinofchaos’s picture

FileSize
195.86 KB

Morbus: Thanks very much for your edits and comments! Mostly I've just implemented them, I'm only responding to the ones that I either disagree with or have questions/comments about.

* Manage your site's content -> too repetitious with the preceding header. Couldn't think of a better one though: "administer your site's data"? Also note that there's no period at the end of this sentence.

Tried a couple of things, stuck with what I had there, other than the .

* How come the menus in the sidebar block aren't alphabetical?

Because we're using the menu system, I'm using weights to control block order--those weights are also used to control menu order.

* Comments -> The moderation queue isn't in core, no?

Comment moderation still is, I think. It's node moderation that isn't.

* Content types -> no period, and don't use "and much more". No marketing.

It's not really marketing; it was a shorthand to say "There's a lot of options here". I felt it was a good idea to convey that.

* Forums -> why are the settings under this menu item?

For very important systems (typically with a lot of settings) I floated their settings to the top level. When I first did this, I was floating all settings to the top, and then I realized that most systems, such as the forums, really didn't want to have their settings separated from their admin interface. There isn't a lot there, it's already the logical place to look, and typically modules will work this way as well.

* Post Settings -> In reading over this organization, it seems odd that "Post Settings" and "Content Types" are two different screens.

I kind of agree, but that's a different patch, I think.

* Don't use the term RSS. Use the term "Syndicated" or "Syndication".

For now, Drupal only supports RSS; I went with RSS as that's what Dries had renamed it to, and I think RSS is more recognizable to people than syndication, anyway. Does anyone else have comments on this one? [For now I've left it RSS].

* Aggregator -> Remove "outside" and "makes available", s/polls/retrieves this data/".

Agreed without removing outside and retrieves over polls, but I want to stress a bit that aggregated data comes from other locations. (aggregate is a difficult word, IMO, and it's not obvious what it really means. It means different things in different contexts).

* Search posts -> No period; can't you search users as well?

Yes but not from this link, oddly.

* User profiles -> "create customizable fields for your users", perhaps? This one needs work.

Possibly.

Updated patch attached. Need to figure out how to do the full length screenshot.

webchick’s picture

Merlinofchaos: Check out the Screen grab extension for Firefox.

Morbus Iff’s picture

Eh oh!

* I'd change "and much more" to just "etc.". Whether it's marketing or not FOR US, "and much more!" is used a lot as such.

* Aggregator: I'm fine with your changes though, to reduce repetition, would make it "what content [you] aggregate".

yched’s picture

subscribing

kika’s picture

I am not entirely happy with the approach this patch is taking (read my reasons in http://lists.drupal.org/pipermail/development/2006-July/017883.html) but I do believe in inceremental improvements, so at least this patch do not make things worse.

Comments:

1) I do not like the hackish feel the style and layout and implementation gives me. So far there is almost no quickhacks for item placements, there is always been an abstraction layer, whenever it was tabs, blocks, notification messages or page descriptions. Now suddenly such a non-standard blocks-that-are-not-really-a-blocks, why?
Why not take a step back on the layout and come up with a compromise using less prominent UI style and something that fits better with all the UIs. It's about the content, right?

I would drop the blocks style at least for now when we do not have finegrained, multi-region, inside-content block system approach in place and go for something similar to http://drupal.org/handbooks -- standard page-wide headers, 2 column links. The same style should possibly continue on admin subpages (see below)

2) why am I allowed to navigate to "content management", "site building" etc subpages using a menu tree, but I can not do it from the main administration page (the block titles are not links)?

3) there seems no logical order in menuitem order, seems like a mismash of weights and alphabetical ordering. It's hard to come up with a superstructure since added modules always mess up the order. So it's either:
-- always a-z
-- bump up -10 some most-used pages (content management > posts, user management > users), let others wrangle in flames of hell (my pick)
-- bump up all default module's items, let added stuff appear in the bottom

4) the mentioned admin subpages look different (no block style)

5) why admin subpages have no page (short or long) description?

6) expert mode: I have mixed feelings about it:
-- I turned it on and never looked back so it is useful for me
-- It's a non-Drupalish behaviour what has no previous precedence. We have came so long way with all the fancy js collapsing for UI clutter handling and now such a 1995ish behaviour.
-- The label is misleading, it's hard to understand what scary thing lies behind that link. Why not "Hide descriptions/Show descriptions"
-- I still think we could do away without that complexity and go for no-descriptions by default with descriptions in link hovers. But it needs to be tested, long texts in tooltips are not always easy to use

7) There are settings that are hard to classify:
-- RSS: is it content management or site configuration? (note that commentrss.module and atom.module want probably live near the rss settings too)
-- contact form: why it is look&feel? should it be site configuration (or content?)
-- file upload settings: content --> site configuration
-- blogAPI: modules --> site configuration (or content?)

8) site configuration > administration settings
"Choose which theme the administration pages should display in. If you choose "System Default" the administration pages theme will not be overridden." -- this overriding thing sounds scary. Why not just say as it is: system default keeps the admin theme same as you have set for your site?

9) Why the default is bluemarine, not System Default (what is bluemarine too)?

Gary Feldman’s picture

Some more comments on the wording:

  • List books and control orphaned ...I'd prefer something like "Manage books" or "List the site's books." The problem is that list and control can be nouns, verbs, or adjectives, so one stumbles trying to parse it (English not being German). It wouldn't be so bad later down, once the pattern of beginning most items with a verb has sunk in, but not as the very first item.
  • Create vocabularies and terms which may be used to categorize your content
  • Comments ->"List and edit site comments and the comment moderation queue"
  • Content type -> "Manage posts by content type, including default status, front page promotion, etc."
  • File uploads -> "Control how files may be attached to content"
  • Forums -> "Control forums" (The rest follows obviously.)
  • Post settings -> "Control posting behavior, such as teaser length, requiring previews before posting, and the number of posts on the front page." [Aside: as I read this, I realize that the last item is misplaced. It's configuring the front page, not posts.]
  • RSS Aggregator -> "Configure which content your site aggregates from other sites, how often it polls them, and how they're categorized.' By the way, I agree with the position that RSS is more familiar than syndication.
  • RSS Feeds -> In addition to the missing article, this gives me no idea of how it's different from the preceding item.
  • Search posts. This is redundant with the posts item above.

That's all the wordsmithing I have time for at the moment, but let me make one more comment. Now would be an ideal time to capitalize these entries. Mixed case is easier to read, and in this situation, much easier to scan.

I hope to go through the rest soon. To paraphrase Elements of Style, most editing is just deleting unnecessary words.

FabriceV’s picture

Dear Mr.
Some modules pertain to site configuration while they can pertain to site building in a more practical approach.
Site information, Localization, Date and time modules could be present in site building because they directly influence how the site looks and feels, and are generelly defined at first. Other modules of site configuration are more technical.

and possibly
clean URL: is there a necessity to maintain two menus and separe configuration with URL aliases?

Dries’s picture

Fabcrice: we're aware of the difficulties but its a difficult problem to solve. What _concrete_ solution do you propose? We can only proceed given concrete solutions that get sufficient support.

Earl: I propose we group all settings in a single block. See mailing list for details.

Let's do another round of minor improvements: some of kika/kristjan's comments really make sense to me - eg "Hide descriptions/Show descriptions" vs "Expert mode".

I think that after another round (or maybe two rounds), this can be committed.

merlinofchaos’s picture

1) I do not like the hackish feel the style and layout and implementation gives me. So far there is almost no quickhacks for item placements, there is always been an abstraction layer, whenever it was tabs, blocks, notification messages or page descriptions. Now suddenly such a non-standard blocks-that-are-not-really-a-blocks, why?

Hackish?! I don't get that.

You're right, though, there are no quick hacks for item placement, because those will go in a later patch. They can become real blocks later on, but I'm trying to take this in small enough steps. The actual underlying code will make it very easy to change things over to blocks if that's the way we decide to go.

2) why am I allowed to navigate to "content management", "site building" etc subpages using a menu tree, but I can not do it from the main administration page (the block titles are not links)?

This could be a link, but in the original design, the blocks had some controls up there that making this a link will cause difficulty to. I don't see that a link there is really important; the sub-pages aren't important, they're only there because Drupal requires them. Ideally I'd want people not even realize they're there.

I would drop the blocks style at least for now when we do not have finegrained, multi-region, inside-content block system approach in place and go for something similar to http://drupal.org/handbooks -- standard page-wide headers, 2 column links. The same style should possibly continue on admin subpages (see below)

I'm not going to go that far. If you want to take over the work and do that, and that's what people want, feel free.

3) there seems no logical order in menuitem order, seems like a mismash of weights and alphabetical ordering. It's hard to come up with a superstructure since added modules always mess up the order. So it's either:
-- always a-z
-- bump up -10 some most-used pages (content management > posts, user management > users), let others wrangle in flames of hell (my pick)
-- bump up all default module's items, let added stuff appear in the bottom

Uh, it's basically option 2. There's only 1 item outside the log section in the whole set that are not a-z. The log section is in the very same order that Drupal had it in, except for the watchdog log which was given a -10. This is a mishmash? I have no idea where you're coming from here.

6) expert mode: I have mixed feelings about it:
-- I turned it on and never looked back so it is useful for me
-- It's a non-Drupalish behaviour what has no previous precedence. We have came so long way with all the fancy js collapsing for UI clutter handling and now such a 1995ish behaviour.
-- The label is misleading, it's hard to understand what scary thing lies behind that link. Why not "Hide descriptions/Show descriptions"
-- I still think we could do away without that complexity and go for no-descriptions by default with descriptions in link hovers. But it needs to be tested, long texts in tooltips are not always easy to use

One of the use cases is for very new users, so no-descriptions by default seems wrong to me, and it's one simple click to turn off the descriptions. I cannot see how this is a bad thing. Expert mode might theoretically do more than just turn off the descriptions in a future version, so I very much prefer that wording.

7) There are settings that are hard to classify:
-- RSS: is it content management or site configuration? (note that commentrss.module and atom.module want probably live near the rss settings too)
-- contact form: why it is look&feel? should it be site configuration (or content?)
-- file upload settings: content --> site configuration
-- blogAPI: modules --> site configuration (or content?)

I agree with all of these. Maybe syndication deserves its own block, to be honest. For the rest, I can move them, none of them really scream to me that they should be anywhere in particular.

Contact form...is it contact or setting? That's a really tough one. blogapi should probably go under site config.

8) site configuration > administration settings
"Choose which theme the administration pages should display in. If you choose "System Default" the administration pages theme will not be overridden." -- this overriding thing sounds scary. Why not just say as it is: system default keeps the admin theme same as you have set for your site?

K, nicer wording is good.

9) Why the default is bluemarine, not System Default (what is bluemarine too)?

Because most themes (in my experience) really hurt the administration stuff, and it seems like a more logical default to use bluemarine (the default theme anyway), which at least is clean and readable for admin stuff. It's easier on new users, I think, and experienced users can change it to whatever they like with ease.

Fabrice:

clean URL: is there a necessity to maintain two menus and separe configuration with URL aliases?

Yes, clean URLs is totally separate in part due to the clean URL test, and 2) because it actually has nothing to do with URL aliases.

Dries:

Earl: I propose we group all settings in a single block. See mailing list for details.

I strongly disagree with this. One of the things that's most wrong with our current setup (IMNSHO) are the questions of 1) what is a setting and 2) why it makes sense to anybody to have a system split its administration tasks and settings. After years of using Drupal, I still have problems finding things, because, well, "What's a setting?" Why should I have to ask that question? I know that I want to administrate the menu system. I look in the admin section, and find menus (if I'm new I probably don't know that menus are site building so yes, I have to find it). Then I go to the menu system. Now I'm mad because menu settings are somewhere else.

In fact, maybe I made an error in floating post settings and user settings up; I gave them more import because they are, IMO, some of the most important settings in the system and I wanted them to be easy to find, but that does lend the problem that they are only *near* the system they are settings for, not *with*. I'll think about that, because the argument that they're so important they need to be called out still carries a lot of weight, IMO.

My other argument against it is that there's Too Many Settings. And when you broke up the main settings page, you added 8 or 9 more. That's a huge block. Why bother with organization at all if you're going to have 25+ items in 1 block and 4 or so items in every other block? As it *is* with the current system, I think the general site config block is too big, but I don't know how to split it down any further.

merlinofchaos’s picture

kika: Ideally I would like to see, in the future, an actual 'administration' theme that is only for the admin, and make that the default. In the absence of that, I prefer bluemarine. IMO.

merlinofchaos’s picture

FileSize
195.54 KB

Newest iteration. Implements the bulk of Gary's fine edits (Thank you Gary! I only skipped one, the bit about forums, where I didn't think the rest actually does logically follow), also implements some of kika's suggestions. Also adds alt/title text to links in expert mode so we can test out kika's idea of using tooltips (my initial thoughts are "no, not a good default")).

merlinofchaos’s picture

Yay, thanks webchick for pointing me at that screengrabber.

Updated screenshot attached.

rkerr’s picture

@#62

1) I do not like the hackish feel the style and layout and implementation gives me.

I'm not comfortable with the dramatic difference in heights of each block. They don't line up in any nice grid-like fashion. To make this act like the handbook index page might not be a ton of extra work. That might look a lot cleaner, actually.

2) why am I allowed to navigate to "content management", "site building" etc subpages using a menu tree, but I can not do it from the main administration page (the block titles are not links)?

Consistency. No other block titles in Drupal are links that I know of. Also, all the information you would get from going to that sub-section is exposed on each block so what do you gain by adding the links?

5) why admin subpages have no page (short or long) description?

Is the description even neccessary on the main admin page? It's just another piece of help text isn't it, so small thing to fix either way.

6) expert mode: I have mixed feelings about it:

I would say just leave "expert mode" out, if all it does is hide the descriptions of each item. It should be able to be themed so that the descriptions are less-intrusive without needing to hide them.

7) There are settings that are hard to classify: RSS: ... file upload settings

RSS is content management to me.
I would be tempted to put file settings under content management.

9) Why the default is bluemarine, not System Default (what is bluemarine too)?

There shouldn't be a "system default" entry.. It should list all the names of the enabled themes, and mark the enabled one with an astrix or something.

paranojik’s picture

The current patch breaks the admin/build/block/list page:
Lines 202-205 of block.module should read:

  // If non-default theme configuration has been selected, set the custom theme.
  if (arg(4)) {
    $custom_theme = arg(4);
  }
merlinofchaos’s picture

FileSize
196.07 KB

Another arg() related error. I corrected it and got rid of the arg() entirely. New patch attached.

pwolanin’s picture

First, I want to say that the screen shot in #69 looks 100x better than the current admin interface, and I really appreciate the hard work that's gone into these improvements.

I do, however, agree with the comment in #70 regarding the columns. I'm willing to take a crack at generate sections that are the full width, but have two columns of tlinks within each block.

merlinofchaos’s picture

pwolinin: Let's file an issue on that once this patch is in? I can see the reasoning and all, but that is, essentially, a matter of theming. (It's actually a relatively trivial change to the current system) and I'd rather it not hold most important part of this patch up.

(Also, there's a bunch of things that could be done with theming, and we could even offer several administrative themes, perhaps in core, perhaps through contrib -- that's how the icons are supposed to come into play, for those that want icons on their admin interface).

merlinofchaos’s picture

FileSize
48.33 KB

rokerr hacked a bit to get a simple version of the handbook-style mentioned above. Screenshot attached.

pwolanin’s picture

obviously I'm too slow on the draw ;-) I only just had time to get the patch installed.

I think this screenshot is better, especially if some of the styling is added back.

Let me know where I can help- either with the code or with the styling/CSS.

paranojik’s picture

The "edit primary links" link (which appears when the primary links are not set) should lead you to the admin/build/menu page.

merlinofchaos’s picture

Here's a variant that uses the exact same styling as the original. Note that the styling on the drupal handbook pages is out of the bluebeach theme and we probably don't want to include that in Drupal itself.

eaton’s picture

I'm agnostic on two-column-boxes versus full-width-boxes-with-two-columns-of-links. It seems like the sort of thing that should be handled by a theming function, and shouldn't hold up the otherwise major work done by this patch.

The 'look of the page' is important, but discussions about the specifics of formatting seem to be eclipsing the work done to reorganize the *structure* of the administrative section. The new layout is good, and has more room to grow than the 4.7 era setup.

rickvug’s picture

From a usability/aesthetic perspective, the layout and styling of #78 is the way to go in my mind. I also agree with Eaton that this could easily be changed at the theme stage. Just change the width and "float: left". I like where this patch is going and will be around to chime in on changes every now and then.

Dries’s picture

Personally, I like #78 best. :-)

Dries’s picture

#78 looks nice when the descriptions are shown but might look weird in 'expert mode'?

Frando’s picture

As a lot of people already mentioned, I think this styling issue shouldn't stop the patch from going in.

The best would be to provide a theme function for that, because then a yet-to-be-created adminstration theme could even add some fancy icons or similar stuff.

Apart from that:
I can't see any serious issues anymore. I'm for RTBC, and then probably fileing some more issues against it later on.

merlinofchaos’s picture

Here is #78 in expert mode:

Given the general reaction (I'm the only one who prefers the original way) I am thinking I should integrate this into the code and post a patch with this theme instead? (Right now it's running as theme overrides to make it easy to switch on and off)

merlinofchaos’s picture

Remaining (almost purely stylistic) questions:

1) capitalize section names? This actually is an interesting conundrum. Drupal doesn't capitalize menu titles, for the most part. Can capitalize them via CSS or PHP as we output the actual admin menu, or we can leave as is. I personally prefer section titles capitalized, but have been going Drupal standard on this.

2) Rename expert mode 'compact' mode? I've grown a little warmer to this idea than I was originally, and maybe 'compact' mode is a much more clear way of thinking of it.

3) I've noticed some issues with the admin theme and actually trying to administrate that theme from admin/blocks. (primarily, when you activate a new theme from admin/themes, if it hasn't been active before it inherits your blocks. I need to replicate this for the admin theme, I think).

merlinofchaos’s picture

4) Is the module management block a good idea? Should this be folded back into site configuration (and weighted to the top?)

Dries’s picture

1. I'm OK with capitalizing titles but maybe it is best left as a seperate patch. We need to capitalize all menu items then.

2. 'expert mode' vs 'compact mode'. I prefer 'hide descriptions / show descriptions' but like 'compact mode' better than 'expert mode'.

3. Don't understand.

4. The module management block is a bad idea, IMO. Should be removed.

5. 'site themes' -> 'themes'. 'site' is redundant. 'look and feel' might be more friendly?

6. 'administration settings': vague link title. It doesn't mean anything. Do you mean 'administration _page_ settings'? If so, write 'administration page' or 'dashboard'.

Dries’s picture

Note that the number of items in the left and the right column are not always well balanced. The difference is sometimes more than one, meaning something is wrong with the algorithm to split the available items in two equal-length lists.

Dries’s picture

I think the next version of this patch is RTBC. We can refine things later on.

We should also prepare some 'module upgrade instructions' to help people upgrade their modules. It's kind of a sweeping change.

kika’s picture

- I still like to change vague 'expert mode' thing into 'show/hide descriptions'. I did not saw any strong arguments against it

- Perhaps it's wise to commit almost-barebone html admin page (something like #75) and start new issue for CSS wizardy and experiments. Arguing over title capitalization seems well out of scope at this point. There are several more related issues like too big left-indent for descriptions, support for all the default themes etc. Let's go step-by-step?

- Both initial proposal and #75ish proposal take time to learn and retrain you motor memory, so I do not really know which is better in long-time usage. My arguments against pseudo-blocks was mostly technical. What others thing, how does the feel differs?

- I somewhat missed the point in "bumping-up" the most common tasks discussion. Is bumping up to #1 placement "user list" and "posts" is good idea or not? (following the example of "watchdog logs")

merlinofchaos’s picture

FileSize
201.49 KB

Ok, another patch attached.

To explain the theming problem above:

If you changed the administrative theme to a theme that had never been activated, all blocks disappeared. I added some submit logic to the settings form to check for this condition and call the appropriate function.

I changed the wording on expert mode to show/hide descriptions.

I made some text changes as per Dries' suggestions.

I removed the modules block and modules is now in site config block at the top.

I made a note in the changelog.

When the patch is committed I'll go add notes on the handbook page about updating modules.

Dries’s picture

Status: Needs review » Fixed

Committed to CVS HEAD! :)

Anonymous’s picture

Status: Fixed » Closed (fixed)