karmakaze [karmakaze]

Hello, and thanks for applying for a CVS account.

There are already projects hosted in Drupal.org repository that implement a Wiki-like input format; as reported in Apply for contributions CVS access, the proposed project must not duplicate the work done in existing projects (duplicating work doesn't mean the code is duplicate).

Yes, I'm aware of the other Wiki-like input filter implementations.

Why then didn't you open feature requests for the existing project (for the features you think are missing on those projects), or didn't you offer to become co-maintainer of one of those projects? As reported in Apply for contributions CVS access, the proposed module should not duplicate work of existing projects.

Looking for any projects that implement a Wiki-syntax input filter, I found at least the following ones:

1. http://drupal.org/project/twikifilter
2. http://drupal.org/project/mediawiki_api
3. http://drupal.org/project/mediawiki
4. http://drupal.org/project/interwiki

@karmakaze: Thanks for the time you took to explain the motivation of creating the proposed modules.

If you attach one of the proposed modules, we can follow with the code review; keep in mind we review just a module / theme per applicant.

I am adding the review tags, and some volunteers will review the code, and point out what needs to be changed.

1. The code can be only released under the same license used by Drupal. When you clicked to apply for a CVS account, you clicked on a checkbox which said that you agreed on committing only code released under GPL License v2.
2. The debug code should be removed.

3. 	if ($long) {
   	  return 'Wiki Creole markup input filter';
   	}
   	else {
   	  return 'Wiki Creole markup input filter';
   	}
   

   The returned strings should be translated.

4. See http://drupal.org/coding-standards for how the code should be formatted, and which character is used for indentation.
5. strlen(), and substr() should be replaced by drupal_strlen(), and drupal_substr().

version = "6.x-0.2.1"
core = "6.x"
project = "creole"
datestamp = "1267548900"

Those lines must be removed from the file, as they are added from the packaging script; having two copies of those lines just confuse the code that verify if an update is available.

A function declaration is written as

function creole_process_links($text) {

The curly bracket is always inline with the keyword function.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

When you update your password for the CVS account, you need to wait 30 minutes for the change to be propagated to the CVS server.

If that doesn't resolve your problem, then it is better you open a support request in queue Drupal.org server administrators; this queue is not followed by server administrators, who can help you with similar issues.