The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem."A function that has acquired a lock may attempt to renew a lock (extend the duration of the lock) by calling lock_acquire() again during the operation. Failure to renew a lock is indicative that another request has acquired the lock, and that the current operation may need to be aborted."
This text is double.
In lock.inc it's on line 41-44 and on line 56-59.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | obtainng.patch | 747 bytes | Anonymous (not verified) |
| #7 | 719500_lock.inc_.patch | 855 bytes | sender |
| #2 | 719500.patch | 1010 bytes | jhodgdon |
Comments
Comment #1
jhodgdonGood catch!
Comment #2
jhodgdonHere's a patch that removes the duplicated text.
Comment #3
jhodgdonAs a note: After this is committed, it needs to be ported to Drupal 6 also. http://api.drupal.org/api/group/lock has the same problem in D6 and D7.
Comment #4
dries commentedCommitted to CVS. Thanks a lot.
Comment #5
jhodgdonFixing title...
Comment #6
sender commentedComment #7
sender commentedPatch for D6.
Comment #8
sender commentedComment #9
jhodgdonThis looks fine to me.
Comment #10
Anonymous (not verified) commentedPerhaps a small typo of a missing 'i' in "obtainng"?
Comment #11
jhodgdonThe patch in #10 does not fix this issue (removing duplicated doc lines). It fixes a separate issue -- a typo that appears in both Drupal 6 and Drupal 7. It needs to be fixed in D7 first, then ported to D6. So I filed a new issue and moved the patch over there:
#791610: Typo in lock.inc
The patch in #7 is still RTBC for Drupal 6.
Comment #12
gábor hojtsyCommitted, thanks.