settings.inc is included twice by drush sql-sync

I was trying to avoid that for performance reasons.

Personally, I think this is a drush bug. Normally, there is no reason to load settings.php twice in a single request, otherwise line 15 of your report would be require_once() instead of require().

   0.4084    7085416  15. require('/var/www/sites/default/settings.php') /usr/local/drush/includes/sitealias.inc:635

Note that conf_init() uses include_once(), so our use of it is redundant and just increases PHP memory strain.

http://api.drupal.org/api/function/conf_init

Moving for discussion. Please make sure this is the right queue.

Cross-post. I already moved it once.

This is not at all easy to fix in drush. A single include_once will hardly affect performance. lets be merciful and just do that. Please. Marking as a dupe as this came up once before.

@moshe

I disagree. Drush is violating how core handles it, and that causes errors in contrib.

And you can't mark it a duplicate if you're going to push the fix back to the original module.

The whole include_once() issue is something I've heard Rasmus rail about more than once, and its a habit Drupal needs to start avoiding.

Either refile to DA, or reconsider, please.

The solution in #0 probably works, but the patch in #7 will not work, can not work, and should not be committed in drush.

From the patch:

   if (file_exists($site_settings_file)) {
     global $databases, $db_url, $base_url;
     $base_url = null;
-    require $site_settings_file;
+    require_once $site_settings_file;
     if (isset($db_url)) {
       $alias_record['db-url'] = $db_url;
     }

The point of this bit of code is to get the 'db-url' out of the settings file and assign it to the alias record. However, if the settings file has already been included, then "require_once" will do nothing, db_url will not be set, and you will have about a 50% chance of the correct db-url being assigned to your alias record, depending on what order they were referenced before.

I can offer you a different solution, though. drush uses backend_invoke to get the db_url from remote sites, and it could use the same technique to get the db_url from local sites. This would entirely remove including / requiring the settings.php file from the site alias code, which I think would be a big improvement.

Unfortunately, I can't roll this patch until next week, but if y'all just hang tight, I'll get it fixed up right quick.

Sorry, I didn't mean to state it quite so strongly as that.

In any rate, this issue is now almost a duplicate of #702554: Look up sitealias database settings only after a full database bootstrap, but one more minor change is needed before things will work right for this use case. The enclosed patch should do the trick.

looks good to me. greg is welcome to commit this if he is ready. otherwise, i can easily do it.

Thanks; committed.

3.0 beta working fine with DA....

I am faced with this same error. I tried making the changes and it still gets the error. This error started when I activated the multisite module, multisite search module. Only way around this is to disable these modules. Must be a conflict between the two. I'm a noob so maybe i'm doing something wrong.

multisite_api
multisite_login
multisite_search

Type cron
Date Friday, April 2, 2010 - 07:12
User JonBr84
Location http://localhost/mysite/?q=admin/reports/status/run-cron&destination=adm...
Referrer http://localhost/mysite/?q=admin/build/modules
Message Cron run exceeded the time limit and was aborted.
Severity warning
Hostname 127.0.0.1
Operations

It happens when the cron is ran, or sometimes when I'm going into the module section in drupal.

Fatal error: Cannot redeclare domain_settings_setup_ok() (previously declared in C:\wamp\www\mysite\modules\domain\settings.inc:39) in C:\wamp\www\mysite\modules\domain\settings.inc on line 44

Everything is up to date. Versions listed below:
Drupal 6.16
Includes: Block, Book, Color, Comment, Contact, Database logging, Filter, Forum, Help, Locale, Menu, Node, Poll, Profile, Search, System, Taxonomy, Tracker, Update status, Upload, User
Modules
Up to dateok
Birthdays 6.x-1.0
Includes: Birthdays
Up to dateok
Chat Room 6.x-2.9
Includes: Chat Room
Up to dateok
Contact Forms 6.x-1.12
Includes: Contact Forms
Up to dateok
Content Construction Kit (CCK) 6.x-2.6
Also available: 6.x-3.x-dev (2010-Jan-25)

* Download
* Release notes

Includes: Content, Option Widgets
Up to dateok
FileField 6.x-3.2
Includes: FileField
Up to dateok
Front Page 6.x-1.2
Includes: Front Page
Up to dateok
Image 6.x-1.0-beta5
Includes: Image, Image Attach, Image Gallery, Image Import
Up to dateok
Image FUpload 6.x-3.0-rc2
Includes: Image FUpload, Image FUpload (CCK), Image FUpload (image)
Up to dateok
ImageAPI 6.x-1.6
Includes: ImageAPI, ImageAPI ImageMagick
Up to dateok
ImageCache 6.x-2.0-beta10
Includes: ImageCache, ImageCache UI
Up to dateok
ImageField 6.x-3.2
Includes: ImageField
Up to dateok
IMCE 6.x-1.3
Also available: 6.x-2.0-beta1 (2010-Mar-17)

* Download
* Release notes

Includes: IMCE
Up to dateok
Interface 6.x-1.0
Includes: Interface, Tabbable
Up to dateok
jQuery UI 6.x-1.3
Includes: jQuery UI
Up to dateok
Lightbox2 6.x-1.9
Includes: Lightbox2
Up to dateok
Multisite API 6.x-1.0
Includes: Multisite API
Up to dateok
OpenID URL 6.x-1.5
Also available: 6.x-2.x-dev (2009-Oct-05)

* Download
* Release notes

Includes: OpenID URL
Up to dateok
User Permissions 6.x-1.0
Includes: User Permissions
Up to dateok
Views 6.x-2.8
Also available: 6.x-3.0-alpha2 (2010-Jan-25)

* Download
* Release notes

Includes: Views
Up to dateok
Webform 6.x-2.9
Also available: 6.x-3.0-beta2 (2010-Mar-01)

* Download
* Release notes

Includes: Webform
Up to dateok
Wysiwyg 6.x-2.1
Includes: Wysiwyg

Use drush-HEAD. Also, please report the problem you are having, do not say "the same error". That doesn't give enough information to tell if the error is actually the same or not.