Mirabuck [mirabuck] [#715378]

CVS edit link for Mirabuck

I am relatively new to Drupal but have been working with PHP and MySQL for nearly a decade. I have a degree in computer science, but my current job involves primarily front end development--working with a university that is converting 850+ sites over to Drupal. 90% of the work I do in a given day involves Drupal in some regard. Our team has created several custom modules already and we look forward to contributing them back to the community once they are in a ready state.

In addition, I've been developing a few Drupal sites on the side including a recent Ubercart site which required a promotion system for purchased roles that didn't appear to exist for D6. It seems to be a good candidate for my first contrib module. I've also done a port from D5 to D6 of the Ubercart Beanstream payment gateway module and would be keen on moving that into contrib as well if the current D5 maintainer has no objections.

Comment	File	Size	Author
#3	uc_role_progression.tar_.gz	1.97 KB	mirabuck

Comments

Comment #1

tr commented 16 February 2010 at 17:06

Please read Apply for contributions CVS access:

You must submit a finished, working module or theme for review along with your application.

Comment #2

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 16 February 2010 at 17:20

Hello, and thanks for applying for a CVS account.

As already pointed out by TR, we give a CVS account because you have a module / theme that you think it's worth to be put in Drupal.org CVS; the email you should have received reports that an archive containing the proposed project should be uploaded here. Differently, we could not review the code, and we don't give a CVS account without reviewing the module code (with an exception that doesn't apply to your case).

Comment #3

mirabuck commented 17 February 2010 at 01:44

Status:

Postponed (maintainer needs more info)

» Needs review

Status	File	Size
new	uc_role_progression.tar_.gz	1.97 KB

Thanks TR and kiamlaluno,

Please find my proposed 'uc role progression' module attached and ready for review.

It adds a UC conditional action that looks up predefined role progressions and promotes users to new roles as old ones expire.

Many thanks to whoever reviews it.

Comment #5

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 17 February 2010 at 09:14

Issue tags:

+Module review

I am adding the review tags; some volunteers will review your code, and point out what needs to be changed.

As per Apply for contributions CVS access, the motivation message needs to be expanded.

Comment #6

mirabuck commented 18 February 2010 at 02:03

Thanks again Kiamlaluno.

My expanded motivational message: UC role progression uses Ubercart's conditional actions in conjunction with the UC roles module. It answers a need for a purchasable role that allows a user to progress through a series of predefined roles according to a set schedule. A possible use case for this: purchased access to an e-learning course wherein each week the user gains access to a new set of nodes.

An admin interface allows role progressions to be easily defined. Users may progress from role x to role y if and only if they already have prerequisite role z. An Ubercart conditional action promotes users to these predefined roles as predecessor roles expire.

I was unable to find an Ubercart solution that could do what's outlined above. I created the module to meet my own needs but see it as something that might be useful to many other D6 Ubercart users. I look forward to improving the module by subjecting it to the scrutiny of Drupal community and intend to maintain the module for as long as it proves to be useful.

Comment #7

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 26 February 2010 at 14:07

Status:

Needs review

» Fixed

      '#title' => t($value . ' is followed by'),
      '#options' =>  $specific_options,
      '#default_value' => variable_get('uc_role_progression_' . $key, array('page')),
      '#description' => t('Select role that follows ' . $value . ' in progression.'),

Use t()-placeholders.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.