I have had problems with the menu not showing up. I checked out the code and saw that the code stops executing at subMenu = dynamic_persistent_menu_get_sub_menu(overMenu) because overMenu is not set. Perhaps it should be set upfront? I see that there is a javascript setting being passed by the module but not being used.

Comments

zyxware’s picture

StatusFileSize
new883 bytes

Here is a patch that will fix the issue. I have also changed the way the onload function is registered

zyxware’s picture

I have indented the code and am submitting the corresponding patch. The patch is taken against the state after applying the previous patch.

zyxware’s picture

StatusFileSize
new2.11 KB

I have commented the javascript code and am submitting the corresponding patch. The patch is taken against the state after applying the previous patch.

yrocq’s picture

Status: Active » Needs work

Good point. However, I can't apply the patches. It seems that there are extra spaces at the beginning of some lines.

zyxware’s picture

Perhaps you could try out the combined patch posted at #728938: Full support for multiple menus. That patch is created against the latest dev version.

zyxware’s picture

Status: Needs work » Active

Did you try the patch versus the latest 2.x release?

yrocq’s picture

I don't understand. Is it a patch for 1.x or 2.x version ? This issue is about 1.x.

yrocq’s picture

Assigned: Unassigned » yrocq

I applied the patch by hand in CVS and created a new stable release, thanks !

Discussions about version 1.2 should take place in #728938: Full support for multiple menus.

yrocq’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.