user_pass_reset_url() has no documentation

Gracious! That function has been undocumented for several Drupal versions. Once it's fixed in D7, please also port fix to D6.

Patch attached.

Needs @param and @return... add1sun is repatching.

Ok, trying again. Not sure my @return is descriptive enough....

Will eventually sort this out. :-P

Hehe.

Excellent, I like #7. :)

Assuming the test bot says OK, of course.

Awesome! Yay for fixing 40-year old bugs! Committed to HEAD. :)

Seems to apply to 6.x too, with a little fuzz.

I don't think webchick actually applied it to Drupal 6?

LOL. Thanks. :) Yes, that's what I meant.

Unless I'm misinformed, our API documentation guidelines do not let types to be specified inbetween @param and the variable name, do they?

New guidelines are in place: Yes they do. It's standard in PHPDoc, and Drupal has adopted that standard.
http://drupal.org/node/1354#functions

Ok, where was this applied to D6? I've looked at a few functions and could not find this pattern being used.

It's a brand new standard. I'm not aware of it being used anywhere in D6, and there are probably only 3 or 4 places that now have it in D7, because only a few patches have been applied to D7 with @return or @param types. I don't think we're planning any wholesale effort to go back and put them in everywhere, just adding them incrementally as we update doc.

So, this is likely the first one that has come up for D6.

However, it's all over PHP doc in general, on php.net etc. It is an industry standard, in other words, and the general idea is to add clarity to documentation of functions...

# patch -p0 < doc-user_pass_reset_url-712598-7.patch
patching file modules/user/user.module
Hunk #1 succeeded at 1439 with fuzz 2 (offset -638 lines).

Anyway here's a patch against current D6

Thanks for the reroll. Definitely looks the same as the D7 patch, aside from the context.

Ok, committed.