Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a catch all issue for cleaning up rdf.module. Only code changes should go here. Many RDF namespaces were added as part of the initial RDF patch but some are not being used in core. Some RDF mappings might need to be aligned upon feedback from the semweb community.
- rename sioc:User to sioc:UserAccount
- remove unused namespaces
Comment | File | Size | Author |
---|---|---|---|
#16 | 712538_16_remove_old_ns.patch | 3.66 KB | scor |
#14 | 712538_14_remove_old_ns.patch | 711 bytes | scor |
#9 | 712538_rdf_cleanup_9.patch | 10.6 KB | scor |
#7 | 712538_rdf_cleanup.patch | 10.56 KB | scor |
Comments
Comment #1
scor CreditAttribution: scor commentedtagging
Comment #2
scor CreditAttribution: scor commentedreminder to add RDF in #615634: Update CHANGELOG.txt to explicitly name new core modules and core modules that have been removed.
Comment #3
sunI can't help, but this sounds critical to me. What if my contributed module tries to implement one of the namespaces we are going to remove here?
If I'm mistaken, then please demote this issue to normal.
Comment #4
scor CreditAttribution: scor commentedthat's not critical. if a contrib module needs a namespace, it can define it via hook_rdf_namespaces(). Even if it's defined twice, there will be not problem as long as the namespaces are the same (see #721082: Prevent conflicting namespaces and move hook_rdf_namespaces() invocation into rdf.module for more details on these cases).
Comment #5
JeremyFrench CreditAttribution: JeremyFrench commentedWouldn't having a large default set of namespaces make #721082: Prevent conflicting namespaces and move hook_rdf_namespaces() invocation into rdf.module less of a problem, even if core doesn't use them all?
Comment #6
scor CreditAttribution: scor commentedsee also the comment on skos:Collection at http://groups.drupal.org/node/44094#comment-154828
Comment #7
scor CreditAttribution: scor commented@JeremyFrench: sure, though we can't possibly include all the existing namespaces out there, plus those which do not exist yet :) we should keep core as lightweight as possible and provide the right APIs for modules to extend it easily, in this case there is hook_rdf_namespaces().
Changes in the patch attached:
- rename
sioc:User
tosioc:UserAccount
per announcement on the sioc mailing list.- update the SKOS mappings of the vocabulary and term entity types to use
skos:ConceptScheme
andskos:inScheme
(comment on gdo and discussion on the SKOS mailing list). usedc:title
as vocabulary name mapping according to the example of the SKOS primer: 2.5 Concept Schemes.- remove non used namespaces (making an exception for
rdf
,owl
andrss
given their foundational role in the Semantic Web).Comment #8
sunExceeds 80 chars.
116 critical left. Go review some!
Comment #9
scor CreditAttribution: scor commentedif only sed would have told me that ;) - thanks sun.
Comment #10
sunNot sure whether there actually is anyone else who could do a technical (RDF) review. Our RDF maintainer did this patch, so I'm going to trust him.
Comment #11
Dries CreditAttribution: Dries commentedReviewed. Looks valid. Committed to CVS HEAD.
Comment #13
scor CreditAttribution: scor commentedreopening this issue to remove a few more namespace which are not used in core. They were left initially since there was a potential conflict of namespace definitions, but now it has been fixed with #721082: Prevent conflicting namespaces and move hook_rdf_namespaces() invocation into rdf.module, we can safely remove them and let modules declare them when needed. Non used namespaces are owl, rdf and rss.
Comment #14
scor CreditAttribution: scor commentedtotally forgot about this small tweaking. here is the patch. no API change, no db update required.
Comment #16
scor CreditAttribution: scor commentedsome tests were arbitrarily using the owl namespace, let's use the rdfs namespace instead. This patch also updates the aligns of the RDF module documentation with the list of namespaces from rdf.module.
Comment #17
JeremyFrench CreditAttribution: JeremyFrench commentedThe patch looks good in itself.
However, is open graph used in core? I did a couple of greps but couldn't find it.
Personally I would rather see Open Graph in core, but that is probably a separate issue.
Comment #18
scor CreditAttribution: scor commentedwe use OG in the standard install profile for annotating the image field, this was added in a separate issue, see patch #632484-44: Update the default profile with the proper RDF mapping.
Comment #19
JeremyFrench CreditAttribution: JeremyFrench commentedIn that case I have no issues with the patch at all.
Setting to Reviewed, it is a small patch so I think one pair of eyes is ok, but please set back if you are not comfortable.
Comment #20
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.