blisstering [blisstering]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review the code of the proposed project.

1. /**
    * Install the initial schema.
    */
   function peanutlabsmedia_install() {
     variable_set('peanutlabsmedia_userid', 0);
     variable_set('peanutlabsmedia_appkey', 0);
     variable_set('peanutlabsmedia_frame_height', 0);
     variable_set('peanutlabsmedia_frame_width', 0);
   }
   
   /**
    * Implementation of hook_uninstall().
    */
   function peanutlabsmedia_uninstall() {
     db_query("DELETE FROM {variable} WHERE name LIKE 'peanutlabsmedia_%'");
     cache_clear_all('variables', 'cache');
   }
   

   There is no need to set Drupal variables on hook_install(); the second argument of variable_get() is the value that will be returned when the variable has not been set before. As Drupal variables are loaded in memory each times Drupal bootstraps, if every module would initialize its persistent variables in that way, the used memory would increase.
   Deleting variables as done in hook_uninstall() is not suggested. The code could delete variables used by other modules. There is nothing that forbids to a developer to create a module called peanutlabsmedia_services, in example, and the code would deleted the variables of that module too.

2. function peanutlabsmedia_perm() {
     return array(
       'Administer Peanutlabsmedia',  
     );
   } 
   

   Permission string should use the verb in lower case (administer nodes, administer users, etc).

3.     'title' => 'Peanutlabs Media Settings',
   

   Strings used as titles should be in sentence case (Peanutlags Media settings).

4.   $items['take-survey/get-points'] = array(
       'page callback' => '_peanutlab_take_survey',
       'type' => MENU_CALLBACK,
       'title' => t('Take a Survey'),
       'access arguments' => array('access content')
     );
   

   To avoid conflict with other modules, the menu path should include the module short name.

/**
 * Include all peanutlabmedia include files.
 */
function _peanutlabsmedia_include() {
  $peanutlabsmedia_path = drupal_get_path('module', 'peanutlabsmedia');
  require_once("$peanutlabsmedia_path/peanutlabsmedia.admin.inc");
}

There is a Drupal function with the same purpose; the module should use Drupal functions, where there are functions suitable for the purpose.

1.   $items['admin/settings/peanutlabsmedia'] = array(
       'title' => t('Peanutlabs media settings'),
       'page callback' => 'drupal_get_form',
       'page arguments' => array('peanutlabsmedia_settings'),
       'access callback' => 'user_access',
       'access arguments' => array('Administer Peanutlabsmedia'),
       'type' => MENU_LOCAL_TASK,
       'weight' => 10,
       'file' => 'peanutlabsmedia.admin.inc',
     );
   

   Menu titles, and descriptions should not be passed to t() as that is already done by Drupal core code.

2.   return "You are not authorized to take a survey. Please " . l('login', 'user/login', array('query' => array('destination' => $_GET['q']))) . " or " . l('Register', 'user/register') . "."; 
   

     if ($oid_hash === $oid_ver && $cmd == "transactionComplete" && $status == "C") { 
       $params = array(
         'uid' => $uid,
         'points' => $miles,
         'description' => 'You earned ' . $miles . ' miles by completing a survey with offerId' . $offer_id,
         'display' => FALSE
       );
   

   Except for what reported in the previous point, strings used in the user interface should be translated. l() should not be used together t(); the first fragment needs to be changed to use url() instead of l().

3. /**
    * Implementation of hook_uninstall().
    */
   function peanutlabsmedia_uninstall() {
     db_query("DELETE FROM {variable} WHERE name = 'peanutlabsmedia_userid'");
     db_query("DELETE FROM {variable} WHERE name = 'peanutlabsmedia_appkey'");
     db_query("DELETE FROM {variable} WHERE name = 'peanutlabsmedia_frame_height'");
     db_query("DELETE FROM {variable} WHERE name = 'peanutlabsmedia_frame_width'");
     cache_clear_all('variables', 'cache');
   }
   

   The code should use variable_del().

  cache_clear_all('variables', 'cache');

That call is already done by variable_del().

      'points' => $miles,
      'description' => t('You earned ' . $miles . ' miles by completing a survey with offerId' . $offer_id),
      'display' => FALSE

The first argument of t() must be a literal string; differently, the script that extracts the string to translate to create the translation template will not be able to extract the string, which would not be translatable (if not in the case another module uses the same exact string, but it's rather difficult it happens, when the string is dynamically changed).
The correct code should use t()-placeholders.

Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.