Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
2 Feb 2010 at 16:14 UTC
Updated:
13 Apr 2019 at 19:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
semantinet commentedComment #2
dman commentedI'd be interested in looking at the code...
Comment #3
avpadernoHello, and thank for applying for a CVS account. We need you upload here an archive containing the module code, so we can review it; it would also preferable a more exhaustive description of the module, as the description given in the motivation doesn't allow to exactly understand what is the purpose of the module.
Thanks again for your willingness in contributing to Drupal.
Comment #4
semantinet commentedHi,
Probably my mistake, I was sure I added the archive with the ticket.
The Drupal module of Headup do 2 very simple things:
1) It adds to every page, just before the
</body>tag, a very simple call to a script:2) It adds a settings page to the site-configuration, where users can enter their "Headup username". If and when a user chooses to enter his Headup username - the embedded script looks like this instead:
When either version of this script is embedded in a user's template - his pages start to get annotated, and act like the text in our homepage: http://www.headup.com/ - that is, when a reader hovers over an annotated word - he gets additional information about this term.
Comment #5
dman commentedThe boring normal stuff:
CVS application point #1
Drupal coding standards point #1
No tabs.
In itself it's not a killer, because the code is mostly tidy otherwise, but if you didn't read point #1 before making this application, that indicates there's a good chance you didn't read points 2 and 3 either...
And that hurts the process.
In the semantic world, linking to the word "here" is considered bad form.
<a href='http://mint1.headup.com/Services/Backoffice/' target='_blank'>here</a>A little more contextual help on the form wouldn't go amiss. If someone inherited a site to maintain and saw the config page, what would they think?
Any reason you didn't use drupal_add_js() instead?
edit oh yeah, it doesn't allow externals. :-B
.. all the above points are just general code review - nothing that I'd say affects the actual CVS application.
Code-wise, this is harmless, and probably a nice addition, so thumbs up from me. It's nice and small, can't see anything that could go wrong.
I'd like to see a very clear blurb and screenshot on the project page about what this does and why. Your description above is pretty good. Again, this isn't a blocker.
Comment #6
avpadernoBasing on the previous comment by dman, I am changing the status.
Comment #7
semantinet commentedThanks for the comments and the time you take for this.
We fit the code to the standards, and took care of the tabs issue.
You can see the product in action here: http://www.headup.com.
Drupal installation instructions are available here:
http://www.headup.com/install.php?platform=drupal
We'll be more than happy to add a blurb and screenshots once we have a project page, they'll probably be similar to what we did for Wordpress here:
http://wordpress.org/extend/plugins/headup-bloggers-widget/screenshots/
Thanks again,
Eitan.
Comment #8
semantinet commentedDear Sirs,
I'm curious as to the state of our review.
Any news would be appreciated.
Thanks,
Eitan.
Comment #9
avpadernoMay you describe the differences between the proposed module, and http://drupal.org/project/snap_preview (the version of Drupal supported by the module is not a difference that we are interested in)?
Comment #10
semantinet commentedDear Kiamlaluno,
Thank you for your response.
1. Whereas Snap "gives nice site previews of external links for users when they mouse over an external link" (according to their description), Headup performs semantic text analysis and entity extraction in order to discover the most important topics in any given text ( see http://blog.headup.com/2010/01/why-we-understand-you ).
2. Furthermore Headup doesn't show link previews at all. It provides dynamic content for any identified entity from a multitude of sources.
Comment #11
avpaderno, and needs to be removed from headup.info; the comment for the hooks should be .
Comment #13
sumit_drupal commentedHi,
I have enable this module but don't know how to use it? I have googled about it but could not get much information about it. when I clicked on Headup settings (admin>>Headup settings) ,it is asking for "Your user id" with a link "get your user id" in title of text box, when I click on this link it is opening in a new window with an XML :
This XML file does not appear to have any style information associated with it. The document tree is shown below.
AccessDenied
Access Denied
E53CF5EEEE1C23D2
−
DPeXSZWWptyx7R1d93unrkDlhg/uTSxnV6S2YaejwYu/WjD+QKU9HoHa8LP8Smzr
So does anyone know about this problem? Any help is much appreciate.
Comment #14
avpaderno