sarhugo [sarhugo]

I installed this module on my site and ran some test transactions. It works. I also read through the code to check that it was properly using the Ubercart APIs. I didn't see anything wrong. I researched existing payment methods and there is no duplication here - this is the only saferpay module available.

The code could use some comments and you should run it through the Coder module and clean up the small number of places where it doesn't conform to Drupal coding standards. This is the only reason I'm marking it "needs work" rather than RBTC.

Looks good to me.

Just two notes:

• It's better to delete each Drupal variable used by the module with a call to variable_del(); the used method could delete variables of other modules.
• It would be better to use drupal_urlencode(), rather than urlencode().