No description of the function is given

Comments

jhodgdon’s picture

Title: Documentation problem with phptemplate_node_submitted » phptemplate_node_submitted() has no doc header

Thanks!
http://api.drupal.org/api/function/phptemplate_node_submitted/6

This function does not exist in Drupal 7, so this is a D6 bug only.

jhodgdon’s picture

Issue tags: +Novice

This function is an implementation of hook_node_submitted, so the doc block is very simple. Good project for a novice.

caligan’s picture

StatusFileSize
new907 bytes

Also documented phptemplate_comment_submitted just above it.

caligan’s picture

Status: Active » Needs review
jhodgdon’s picture

Status: Needs review » Needs work

These are hook implementations. Please follow the doc standards for documenting them. You can leave the extra descriptions in there, but they need to have the standard line too.
See http://drupal.org/node/1354#hookimpl

caligan’s picture

Status: Needs work » Needs review
StatusFileSize
new873 bytes

Thanks. :) I was mistakenly looking at the standard function section instead.

I'm unclear, though, on whether I should reference them as implementations of hook_node_submitted or theme_node_submitted, the latter of which shows up on an API search. That's the one I've used here (favoring search results), but if hook_ is more appropriate I'll tweak it.

jhodgdon’s picture

Status: Needs review » Reviewed & tested by the community

Ah.

You are correct, those are theme hook implementations, not hook implementations.

Sorry about that. Let's go back and use the patch in #3, which is consistent with the other functions in the theme/garland/template.php file.

gábor hojtsy’s picture

Committed, thanks.

gábor hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.