I've done a large update of this module to fix up some problems with the sample code (preview handling, permission checks), make it more configurable and add a mode to support multiple attachments just like upload.module.
Also helps to have this fix for upload.module.

CommentFileSizeAuthor
#1 comment_upload.module.patch13.07 KBeaton
comment_upload_0.module9.65 KBmindless

Comments

eaton’s picture

eaton commented
Title: Code refactor, more configurable, support multiple attachments » Comment_Upload: Code refactor, more configurable, support multiple attachments
StatusFileSize
new comment_upload.module.patch13.07 KB

Rolled it as a patch for those who require such things. The module has changed enough that it's probably easier just to use the original version, though. Testing shortly. Thanks!

ec’s picture

ec commented

Hy,
Eaton thanks for this module and Mindless thanks for your contribution that enhance the module which was for me much needed. Mindless adds works fine but we need to update the database first and the "nid" field :

ALTER TABLE {comment_files} ADD nid int NOT NULL default '0'

Regards, eric

eaton’s picture

eaton commented

Well, I've had a chance to look at it and it does look good. I whipped up a short modified version of comment_install that automatically populates the new nid field correctly for any existing attachments.

The only concerns I have (at the moment, at least) are the loss of automatic 'inlining' of images. That was actually one of the things I first needed this module for, so I'm hoping we can preserve the feature.

So far, though, it's looking great. More testing to come...

mindless’s picture

mindless commented

The inline image feature is still available in single-attachment mode. I didn't support that for multiple attachments for two reasons: (a) I don't need it for our site :-) and (b) I wasn't sure how to handle multiple attachments with either multiple images or a mix of images and non-images. If you can advise on (b) I can take a look at adding inline image support for multiple-attachment mode. I guess the most obvious way would be show each image attachment inline, and if any are left after processing those then show the attachments box.

eaton’s picture

eaton commented

Holy cow.

OK, I just went through and realized (much to my chagrin) that my initial testing verified that the comments were working but skipped over the settings screen. Which explains why I thought comment inlining was no longer available. Heh.

After some testing, I think it's a good solution. In the future, a patch to make complicated inlining scenerios simpler would be great, but this is excellent work and should be committed. I'm going to give a little more love to the upgrade procaess for old comment_upload data and get the .install file upgraded, then commit.

Thanks for the excellent work on this!

eaton’s picture

eaton commented
Status: Needs review » Fixed

After some additional testing, this has been committed under the CVS branch. I'm going to give it a *little* bit more time before making it the official 4-7 version, but I think it should be good to go. Thanks for the excellent work!

mindless’s picture

mindless commented

Yay! Thanks :-)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)