Features changes the node module to 'features' instead of 'node' so the permissions don't get created if you have nodes created in features.

CommentFileSizeAuthor
#5 688438.patch559 bytestchurch
#1 content_unpublish.module.688438.patch768 bytesrandallknutson

Comments

randallknutson’s picture

randallknutson commented
Status: Active » Needs review
StatusFileSize
new content_unpublish.module.688438.patch768 bytes

Created a small patch to fix it by checking for features as well.

tchurch’s picture

tchurch commented
Status: Needs review » Needs work

Can I suggest that this whole if statement is removed?

There are lots of other modules that create nodes (i.e. the Storm module).

It would be much better to create permissions for every node type.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Yeah, I think removing the line is correct, I try to remember why I had it the first place..

tchurch’s picture

tchurch commented
Title: No permissions from nodes created with features module » No permissions from nodes created with other modules

Title changed as other modules also affected.

Will someone be patching this?

tchurch’s picture

tchurch commented
Status: Needs work » Needs review
StatusFileSize
new 688438.patch559 bytes

OK. Here is a patch then.

tchurch’s picture

tchurch commented

Just wondered if someone that checked the patch and was going to implement it.
I don't know why but the testbot hasn't tested the patch.

tchurch’s picture

tchurch commented

It anything happening to this patch?

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Fixed

Committed with some more code cleanup, I'll probably create a new release in a couple of days, as long as no other bugs are found. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.