CVS edit link for cronix

I am currently developing a Drupal module based on the OpenFlights.org project. This will result in an application that shows airline flight information in Drupal. Future versions will include the possiblity for users to log their own flights and map them on the OpenFlights map.
CommentFileSizeAuthor
#3 openflights-6.x-1.x-dev.tar_.gz3.1 KBcronix
#1 openflights-6.x-0.1.tar_.gz8.33 KBcronix

Comments

cronix’s picture

cronix commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new openflights-6.x-0.1.tar_.gz8.33 KB

Initial start of an OpenFlights module for Drupal (based on www.openflights.org). The initial admin form is working. Loading of the database is working. De integration with the openflights functionality is next to be implemented.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
  1. Re-arrange the code, so that you can avoid to unconditionally include two files; there is no need to have a separate file to just define constants.
  2. The file LICENSE.txt needs to be removed; Drupal.org CVS doesn't allow to commit that file.
  3. See the Drupal coding standards to understand how a module code should be written. In particular see how the code should be formatted.
cronix’s picture

cronix commented
Status: Needs work » Needs review
StatusFileSize
new openflights-6.x-1.x-dev.tar_.gz3.1 KB

1. Fixed. Agree with the comment. The module is far from ready. The API file will contain a lot more; the constants will be more in place when the API is ready.
2. Removed.
3. Formatted all the code. Added comments to all functions.

Again. This module is not finished by far. The administration form is working though. I have added the latest DEV.

cronix’s picture

cronix commented

How will this continue? Will this be reviews again, so that I can create my project?

tyabut’s picture

tyabut commented

You should finish your module then have it reviewed.

From the Apply for contributions CVS access page:
"Many people write good motivation messages and then mess it up right at the end with "here's a link to my contribution, it's about 75% done". Please, when applying for a CVS account supply a link to your contribution that you believe is complete. Attempting to review uncompleted work is difficult and time consuming (yes, remove all those dpr() and self reminder comments). Reviewing completed work is much simpler as there is already a level of expectation in the reviewer. Try to make our job of reviewing your work a joy."

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

I am changing status as per previous comment.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

There have not been replies in the last week. I am marking this application as won't fix.