Running the Coder module on uc_ajax_cart reveals thousands of violations of the Drupal Coding Standards. This patch fixes most of the 'normal' level problems reported by Coder. However, there are hundreds of 'minor' level problems remaining. Hopefully this patch takes you a long way towards making your code clean.

Note that the patch is over 1000 lines long, because almost every single line in several files needed to be changed.

Please, PLEASE familiarize yourself with the Drupal coding standards - your style is so far outside the norm for Drupal that your code is very hard to work with and understand. Even if you don't agree with some of the choices Drupal has made with these standards, they *are* the community standards, and all code in CVS is supposed to conform to these standards.

Files: 
CommentFileSizeAuthor
#2 uc_ajax_cart.coder_.patch34.98 KBTR

Comments

TR’s picture

Status:Active» Needs review
TR’s picture

StatusFileSize
new34.98 KB

It would help if I remembered to attach the patch ...

Erik Seifert’s picture

Status:Needs review» Closed (won't fix)

Thanks for your patch, but i wont fix this.

Because we have our own coding conventions. Our IDE's and all other software is we use, is configurated to our standards. Its too much time and afford for me to have 2 coding standards.

If you want to participate you are welcome.

japerry’s picture

Priority:Normal» Critical
Status:Closed (won't fix)» Needs review

Drupal standards exist for the community to be able to contribute. This is an easy issue to fix and critical for community participation.

If you do not want to fix or accept this patch, I'll put a request in for this module to be forked and this version of the module to be removed.

Thanks TR for the patch.

Erik Seifert’s picture

Status:Needs review» Closed (fixed)
Erik Seifert’s picture

Status:Closed (fixed)» Fixed

Will be fixed in 2.0-beta1

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.