Normally, I'd think this would be out of scope this late into the D7 cycle. But, we very recently gotin, which brings the '__' suggestion convention out of obscurity and into core. Also, we recently got in, which raises the priority of improving performance of theme hooks implemented as templates. One thing that helps is a static variable cache in drupal_discover_template() ( ), but with this issue, we can get rid of that function entirely, and have even better performance. Finally, we have (had it in D6 too, nothing new) an annoying clobbering WTF: because '-' is used to delimit both multiple word hook names and suggestion suffixes.
So, on balance, I think this patch is worth it. I'll post benchmarks soon.
Just to clarify, the net effect of this patch is that instead of node-TYPE.tpl.php, you would use node--TYPE.tpl.php.
Failed on MySQL 5.0 InnoDB, with: 16,637 pass(es), 4 fail(s), and 1 exception(es). View