Edit links in forum structure page are wrong URL

Ah.

The problem is in function forum_overview() in module/forum/forum.admin.inc.

It is asking taxonomy to build the edit page, and then attempting to modify the editing links, so:

      $form[$key]['view']['#markup'] = l($term['name'], 'forum/' . $term['tid']);
      if (in_array($form[$key]['#term']['tid'], variable_get('forum_containers', array()))) {
        $form[$key]['edit']['#markup'] = l(t('edit container'), 'admin/structure/forum/edit/container/' . $term['tid']);
      }
      else {
        $form[$key]['edit']['#markup'] = l(t('edit forum'), 'admin/structure/forum/edit/forum/' . $term['tid']);
      }

However, if you look at $form, you find that both the 'view' and 'edit' components that are being modified have #type='link':

Note: this is print_r output...
           [view] => Array
                (
                    [#type] => link
                    [#title] => (name of my forum container)
                    [#href] => taxonomy/term/1
                )

Then in http://api.drupal.org/api/function/drupal_pre_render_link/7 when this element is pre-processed, the #markup property added by our forum_overview function is being overwritten by the pre-processing step, so it goes back to what the Taxonomy module set up. So the forum module either needs to override the title/href propoerties, or set the type to markup, for this to work as intended.

Now it just needs a patch. :)

This patch will probably do the trick... I'll make sure in a sec and make a screen shot, meanwhile letting the testing bot loose on it.

This one works better.

Tests, what a good idea! So that if the structure of the taxonomy list changes again, the forum links won't break without us knowing about it? What a concept! :)

Sorry, must be punchy this morning.... I am seriously in love with the testing framework though, and I think getting that into D7 and setting up the test bot was the single greatest achievement for D7. Even better than Fields in Core, though that's a close second.