Hi, I try now to manually alter my Meta Tags on my terms.
I do not get a warning or error, but the Meta Tags information is not saved...

A very strange thing is also that the Meta Tabs link is situated under the [SAVE] button. Could that have to do with it? (See attached picture)

Thanks for going into this.
Greetings,
Maritjn

Files: 
CommentFileSizeAuthor
#31 nodewords-n672096-31.patch1.83 KBDamienMcKenna
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch nodewords-n672096-31.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]
#10 tax_hook_constant.patch1.32 KBjenlampton
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch tax_hook_constant.patch.
[ View ]
metatags_taxonomy.jpg136 KBSummit

Comments

Summit’s picture

Hi,

Also on vocabulary level : admin/content/taxonomy/edit/vocabulary/[vid] the altered Meta tag description and keywords are not saved..
Greetings, Martijn

Summit’s picture

Hi,

I tried to debug this myself..but am just an amateur...
It seems that the taxonomy tags are not correctly processed through

function nodewords_taxonomy($op, $type, $object = NULL)
It seems that $type = 'term' and not NODEWORDS_TYPE_TERM = 6.
the same with vocabulary.

So I changed the function amateuristic to:

function nodewords_taxonomy($op, $type, $object = NULL) {

  if ($type == NODEWORDS_TYPE_TERM || $type == 'term') {
    if ($type == 'term') { $type = NODEWORDS_TYPE_TERM; }
    $id = $object['tid'];
  }
  elseif ($type == NODEWORDS_TYPE_VOCABULARY || $type == 'vocabulary') {
  if ($type == 'vocabulary') { $type = NODEWORDS_TYPE_VOCABULARY; }
    $id = $object['vid'];
  }
  else {
    return;
  }

  switch ($op) {
    case 'delete':
      nodewords_delete_tags($type, $id);
      break;

    case 'insert':
    case 'update':
      if (isset($object['nodewords'])) {
        nodewords_save_tags($type, $id, $object['nodewords'], TRUE);
      }
      break;
  }
}

Hopefully helps this for you to get the error.

Greetings,
Martijn

kiamlaluno’s picture

Title:Taxonomy/term Meta Tags not saved!» Meta tags are not saved for taxomony terms or vocabularies
Status:Active» Fixed

The cause of the error was the use of a constant that doesn't match the value passed to hook_taxonomy().

I changed the code, and now the hook is implemented in this way:

<?php
function nodewords_taxonomy($op, $type, $object = NULL) {
  if (isset(
$object)) {
    switch (
$type) {
      case
'term':
       
$type = NODEWORDS_TYPE_TERM;
       
$id = $object['tid'];
        break;

      case
'vocabulary':
       
$type = NODEWORDS_TYPE_VOCABULARY;
       
$id = $object['vid'];
        break;

      default:
        return;
    }
 
    switch (
$op) {
      case
'delete':
       
nodewords_delete_tags($type, $id);
        break;

      case
'insert':
      case
'update':
        if (isset(
$object['nodewords'])) {
         
nodewords_save_tags($type, $id, $object['nodewords'], TRUE);
        }
        break;
    }
  }
}
?>

Thanks for your report, and the help.

kiamlaluno’s picture

I have marked #673086: Meta tags KEYWORDS and DESCRIPTION are not saved as duplicate of this report.

gafir777’s picture

Hello,

I'm having the same issue with 6.x-1.11. Has the fix been implemented in the version 6.x-1.11 ?

Thanks,

Summit’s picture

Hi, no in the dev version, the maintainer said that after releasing a version, code-changes are only submitted in the future .dev releases. I hope I tell this right, because I am not the maintainer of this great module!

But the current dev version is also having problems, see: http://drupal.org/node/673624 ..hopefully small issue for the maintainer.

Greetings,
Martijn

kiamlaluno’s picture

@Summit: What you report is correct; an official release cannot be changed, after it is released.
I was once used to change the referring version to make clear where the issue was fixed, but I was told that it could confuse people who would not know which version had the issue.

kiamlaluno’s picture

I have marked #679852: Meta tags are not saved for taxomony terms as duplicate of this report.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jenlampton’s picture

StatusFileSize
new1.32 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch tax_hook_constant.patch.
[ View ]

@kiamlaluno -

When you fix a bug, can you please provide a patch against the current release for the rest of us to use? It's much safer to run a patched version of 6.x-1.11 rather than a dev version on a live site.

Thanks,
Jen

tharrison’s picture

Thanks for making the patch file, Jen.

kiam’s picture

Status:Closed (fixed)» Fixed

I have marked #763204: Not saved metatags for taxonomy term in database as duplicate of this report.

To reply of why I didn't attach a patch for version 6.x-1.11, I work on the development snapshot; that is the reason I cannot attach a patch for an official release (which is different from the development snapshot).

Rameez’s picture

@jenlampton How to apply this patch? please say in simple steps? Thanks

venusrising’s picture

Does anyone know what version to use that works? OR if there is something else that will do the same thing that is stable. This is a real mess to follow.

venusrising’s picture

Status:Fixed» Active

Will #10 work to fix this version until another stable release happens?

kiam’s picture

Status:Active» Fixed

See any official release created after this issue has been set as fixed.

venusrising’s picture

Status:Fixed» Active

what does this mean? Is there any version of nodewords that works without issue i.e all parts of the module work like saving other pages etc? It is hard to tell when people are making patchs but then they do not apply. Thanks for your hard work.

kiam’s picture

This issue report has been marked as fixed on January 2, 2010 − 05:14 AM GMT. This means that about 7 hours later the script running on Drupal.org created a new package for the development snapshot which contained the fixed code; the first official release created after that development snapshot contains also the fixed code because the official releases are always created from a development snapshot.

If there is anything else that is not clear, please let me know.

venusrising’s picture

So just to be clear, am I understanding this correctly?
1. when you do a fix it is applied to the dev version OR
2. Is the fixes applied to the stable versions & then we would just overwrite the stable version and run update php.

The reason I ask is I tried to go to dev from 6x 1.11 and I got errors.

Thank so much for your hard work.

venusrising’s picture

Do you mean January 12? I do not see any releases for January 2nd

kiamlaluno’s picture

It's January 2, 2010; see comment #3. About 7 hours later, a new development snapshot has been created. The official release is the first one created after that date; an official release can be created even 7 days later (or even more), as an official release is usually created when more than one issue is fixed.

You understood correctly when you say that the code is first fixed in a development snapshot; that is how Drupal modules hosted on Drupal.org are developed.

kiam’s picture

Status:Active» Fixed
tomsm’s picture

subscribing

onetrader’s picture

subscribing

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

venusrising’s picture

Priority:Normal» Critical
Status:Closed (fixed)» Active

This NEW version of 6.x-1.11 Does not save any info on other pages, What can be done to fix this, we have a production site and this has really damaged a great deal of work and we are trying to dig out of it. Any input would be appreciated.

kollo-dherbois’s picture

"Will #10 work to fix this version until another stable release happens?"

It fixed problem with saving taxonomy term`s metas for me.

kollo-dherbois’s picture

"This NEW version of 6.x-1.11 Does not save any info on other pages, What can be done to fix this, we have a production site and this has really damaged a great deal of work and we are trying to dig out of it. Any input would be appreciated."

Why you call 6.x-1.11 new version? It`s release date is 2009-Dec-31. I do not experience such problem with 6.x-1.11 as you mention. I might guess there some wrong settings you applied - try different options and see what happens. Nodewords UI is quite entangled, so sometimes you would get things you not expected.

mcurry’s picture

Sub :D

DamienMcKenna’s picture

Status:Active» Needs review
StatusFileSize
new1.83 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch nodewords-n672096-31.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.
[ View ]

Rerolled jenlampton's patch from #10 above for the latest 6.x-1.x branch.

Status:Needs review» Needs work

The last submitted patch, nodewords-n672096-31.patch, failed testing.

DamienMcKenna’s picture

Version:6.x-1.11» 6.x-1.x-dev
Status:Needs work» Needs review

Re-running the last patch against the correct code version.

DamienMcKenna’s picture

#31: nodewords-n672096-31.patch queued for re-testing.

Dave Reid’s picture

Status:Needs review» Fixed

Re-applied the commits from this issue, so this should be good now.

u210ks’s picture

subscribing

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

koppie’s picture

I can confirm that the latest dev version (6.x-1.x-dev 2011-9-13) works!

halloffame’s picture

The latest dev version ought to solve my 'not-saving' problem but the fieldset still goes under save button. Weight should be fixed as well.