CVS edit link for hungdo

We have built a Drupal theme, which has several thoudsands of downloads, so we would like to contribute to Drupal community.

The demo site is here: http://demo.symphonythemes.com/conch

CommentFileSizeAuthor
#7 conch_v0.1.2.zip281.63 KBhungdo
#5 conch_v0.1.1.zip282.39 KBhungdo
#1 conch.zip298.04 KBtuthanh

Comments

tuthanh’s picture

tuthanh commented
StatusFileSize
new conch.zip298.04 KB

Here is the package. Thanks.

tuthanh’s picture

tuthanh commented
Status: Postponed (maintainer needs more info) » Needs review

Oops, I forgot to change the status to "needs review".

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
  1. Files available from third-party sites should not be included in Drupal.org CVS. 
  2.       <div class="terms"><?php print $terms ?></div>

    Always use the semicolon at the end of a PHP instruction.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +Theme review
hungdo’s picture

hungdo commented
Status: Needs work » Needs review
StatusFileSize
new conch_v0.1.1.zip282.39 KB

I have fixed that. Could you please review it?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

If the file fixie.js is not a third-party file, then it should be changed to use jQuery.

hungdo’s picture

hungdo commented
Priority: Normal » Critical
Status: Needs work » Needs review
StatusFileSize
new conch_v0.1.2.zip281.63 KB

I have removed fixie.js file and change to use Jquery. Please review it?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Critical » Normal
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)
Issue tags: -Theme review

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Theme review

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Assigned: Unassigned » avpaderno
Issue summary: View changes