-redShadow- [redshadow]

1. function poweradmin_list_domains() {
     $res = db_query("SELECT d.*, count(distinct r.id) AS count_records
       FROM {domains} d LEFT JOIN {records} r ON r.domain_id=d.id
       GROUP BY d.name, d.id, d.type ORDER BY d.name");
     return _poweradmin_dbres_to_array($res, 'id');
   }
   

   The code should use db_distinct_field(). Reserved words should be written in upper case (see COUNT()).

2. function poweradmin_get_domain($domain_id) {
     $res = db_query("SELECT * FROM {domains} WHERE id=%d", $domain_id);
     $domain = db_fetch_object($res);
     $domain->records = poweradmin_list_records($domain_id);
     //dpm($domain);
     return $domain;
   }
   

   It would be better to use db_query_range() to limit the number of returned results to 1.

3. I think that the respect of the namespace extends also to the database tables; the code uses table names as records, supermasters. Somebody could create a module named supermasters, and use a table named supermasters too.

4.   t("Deleted record: %name", array("%name" => $record->name .' '. $record->type .' '. $record->content));
     $form_state['redirect'] = POWERADMIN_ADMIN_ROOT .'/zones/'. $record->domain_id;
   

   The function t() doesn't show anything to the user; its purpose is different.

5. There are some functions that contains a line that seems to mark them as deprecated. Remove those functions, and remove all the debugging functions / output.
6. The file LICENSE.txt needs to be removed; Drupal.org CVS doesn't allow to commit that file.

I already reported to redShadow in IRC the little changes he could do; there is nothing that could stop this application approval, anyway.