Inside system_modules_submit() we already call menu_rebuild(). So, it's pointless to do it again in hook_uninstall(). Splitting this fix out from #669556: Move update_requirements to update.install since this is unrelated to that patch.

CommentFileSizeAuthor
#4 669714-4.update_uninstall_no_menu_rebuild.d6.patch510 bytesdww
#1 669714-1.update_uninstall_no_menu_rebuild.patch592 bytesdww
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Status: Active » Needs review
FileSize
669714-1.update_uninstall_no_menu_rebuild.patch592 bytes
moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Though it's not showing on the patch itself for some reason, if you go over to qa.drupal.org, it came back green.

Committed to HEAD.

dww’s picture

dww
we/he/they
CreditAttribution: dww commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Reviewed & tested by the community
FileSize
669714-4.update_uninstall_no_menu_rebuild.d6.patch510 bytes

Yay, thanks. Here's a clean D6 backport.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Performance

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Performance

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.