I upgraded to 1.9 last night and now I have a big red error "There are no modules that implement meta tags." showing on many of my pages. All included modules are enabled so don't know what modules it's looking for. It looks like it's only showing up for admins so it's not critical but it's annoying. Is there any way I can shut this off?

Thanks,

Michelle

Files: 
CommentFileSizeAuthor
#17 nodewords-669272-17.patch801 bytesDamienMcKenna
PASSED: [[SimpleTest]]: [MySQL] 127 pass(es).
[ View ]
#13 nodewords-n669272.patch983 bytesDamienMcKenna
PASSED: [[SimpleTest]]: [MySQL] 127 pass(es).
[ View ]

Comments

kiamlaluno’s picture

Status:Active» Fixed

I think I fixed the problem with the last commit I made. I changed the value returned from hook_nodewords_api(), which was a floating point value and it is now a string; that value is passed to version_compare(), and it could have caused the failure of the versions comparison.

I also changed the error message reported in such cases; now it points out that there are no modules implementing meta tags, or that support the current API version.

Thanks for the report; I apologize for any trouble given by this issue.

Michelle’s picture

Thanks, I'll update when the new dev comes out this evening and let you know.

Michelle

Michelle’s picture

Ok, dev installed and fix confirmed. Thanks!

Michelle

kiamlaluno’s picture

Thanks to you for pointing out the problem. I don't really know why it was working, last time I checked it.

I will change the code to make it enable nodewords_basic.module, if it doesn't find any modules implementing meta tags. I think this should be a better solution.

Michelle’s picture

Glad it was a quick fix. :)

You can also put it in the status report rather than an error on every page.

Michelle

kiamlaluno’s picture

The message is also reported in the status report, but it actually checks if there are modules implementing meta tags, not the actual version implemented.

I put the message in the settings page because I had some reports about the meta tags not being listed in the settings page. I think that I will remove the error message, and add that code that enables nodewords_basic.module in the case it is not enabled, and there aren't any module currently defining meta tags (or supporting the current API version).

kiamlaluno’s picture

FYI, I removed the code to automatically enable nodewords_basic.module.
I was too focused on finding a solution that would not require the user to do anything that I forgot a detail; if the user would be uninstalling Nodewords, that code would not allow to disable the modules because it would re-enable nodewords_basic.module if the other modules are not enabled.

I apologize for my stupidity.

Michelle’s picture

Oh, I hadn't thought of that. :)

Michelle

nbluto’s picture

Thank you so much for fixing this. I just noticed this weekend that that bug existed on a site that will go live tomorrow! Nice to look for an answer and find it right away.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gr33nman’s picture

Version:6.x-1.9» 6.x-1.13
Status:Closed (fixed)» Active

Drupal 6.24
Just updated all modules.
Had to disable nodewords for this message:

Enable at least a module listed under the category Meta tags in modules pageArray
There are no modules that implement meta tags.

The link on 'pageArray' led to '/sites/reports/status@modules'

After re-enabling, the oddness disappeared. Cannot reproduce.

DamienMcKenna’s picture

Status:Active» Needs review
StatusFileSize
new983 bytes
PASSED: [[SimpleTest]]: [MySQL] 127 pass(es).
[ View ]

The module's logic seems fine, but I've tweaked the language a little.

DamienMcKenna’s picture

Status:Needs review» Fixed

Committed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kenheim’s picture

I applied the patch, cleared cache, but the error message below remains in my status report.

"Enable at least one module listed under the Meta tags category on the modules page.Array
There are no modules enabled that implement meta tags."

DamienMcKenna’s picture

Version:6.x-1.13» 6.x-1.x-dev
Status:Closed (fixed)» Needs review
StatusFileSize
new801 bytes
PASSED: [[SimpleTest]]: [MySQL] 127 pass(es).
[ View ]

#facepalm.

DamienMcKenna’s picture

Status:Needs review» Fixed

Committed.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.