drupal_add_link() adds an extra unwanted newline [#668714]

When you use drupal_add_link(), it adds an extra newline before passing the data to drupal_set_html_head(). The problem is that drupal_set_html_head() *also* adds a newline to each output. So if you use drupal_add_link(), you get output like:

<link href="http://mysql.drupal6dev.local/opensearch/node" title="mysql.drupal6dev.local node search" rel="search" type="application/opensearchdescription+xml" /> 
 
<link href="http://mysql.drupal6dev.local/opensearch/user" title="mysql.drupal6dev.local user search" rel="search" type="application/opensearchdescription+xml" /> 
 
<link href="http://mysql.drupal6dev.local/opensearch/advanced_help" title="mysql.drupal6dev.local advanced_help search" rel="search" type="application/opensearchdescription+xml" /> 
 
<link href="http://mysql.drupal6dev.local/opensearch/location" title="mysql.drupal6dev.local location search" rel="search" type="application/opensearchdescription+xml" />

Comment	File	Size	Author
#3	668714-drupaladdlink-newline-D6.patch	589 bytes	boombatower
#2	668714-drupaladdlink-newline-D6.patch	625 bytes	dave reid

Comments

Comment #1

dave reid

he/him

English

Nebraska USA

commented 27 December 2009 at 18:52

You can even see the result in the source code of drupal.org's frontpage:

<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en"> 
 <head> 
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> 
  <!-- Note: does not validate. We would like it to, but that would mean reduced user experience for the majority of our visitors. --> 
  <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> 
<link rel="alternate" type="application/rss+xml" title="drupal.org RSS" href="http://drupal.org/node/feed" /> 
 
<link rel="shortcut icon" href="/misc/favicon.ico" type="image/x-icon" /> 
  <title>drupal.org | Community plumbing</title>