CVS edit link for thegreat

I have written a module called Drupal SoundCloud and would like CVS access so I can host and maintain it on drupal.org.

Drupal SoundCloud allows sites to associate a user's SoundCloud (http://soundcloud.com) account with their Drupal user account. Using the SoundCloud api, the module then fetches the user's SoundCloud track data and exposes it to Drupal.

The module currently adds a music tab to the Drupal user's account page (@ http://sitename.com/user/%uid%/music) which displays all the user's tracks as a set of links in an unordered list.

I have also included a second module (to be packaged with Drupal SoundCloud) called Drupal SoundCloud Player. This is a custom JQuery frontend for the SoundManager player library (http://www.schillmania.com/projects/soundmanager2/#home) and SoundCloud music streaming service. Drupal SoundCloud Player turns an unordered list of SoundCloud track links into a streaming music player and playlist.

As there is already a module for SoundManager (http://drupal.org/project/soundmanager2) I have developed Drupal SoundCloud to utilize it and included it as a dependency.

The player comes with a simple default theme that is designed to be compatible with the Garland theme. However I have written the player to make use of the Drupal JQuery theme functions allowing the player and it's generated markup to be fully overridable/customizable.

I started writing Views 2 integration and have included a Drupal SoundCloud Player Views style plugin. This allows site Administrators to create lists of SoundCloud tracks using Views and have them rendered as functional streaming players.

The modules are currently available from my github repository here: http://github.com/thegreat/Drupal-SoundCloud. Feel free to take them for a spin and report any feedback you have.

Please note: There is a Drush Make file in the repository's root folder that will deploy a codebase with all the module dependencies required to test Drupal SoundCloud. However the module's still need to be configured (particularly SoundManager2) before it will work.

A little bit about me:
My name is Tom Nightingale, I have been developing sites with Drupal for the last four years. I currently work for Affinity Bridge (http://affinitybridge.com - new site design coming soon!! =D) as a developer. I have been working very hard to strengthen my Drupal skills and feel I am finally able to start contributing back to the community.

If you have any issues with my application, please let me know and I will make the required adjustments right away.

Thanks,
Tom

CommentFileSizeAuthor
#8 thegreat-Drupal-SoundCloud-9bd1e9a.tar_.gz185.96 KBtnightingale
#7 thegreat-Drupal-SoundCloud-ddaba4d.tar_.gz185.96 KBtnightingale
#3 thegreat-Drupal-SoundCloud-2774235.tar_.gz185.98 KBtnightingale

Comments

arianek’s picture

arianek commented

Just wanted to pipe up and vouch for Tom. I've been working with him for about 16 months now - he's an incredibly talented developer, has a keen eye for standards, and is steadfast in learning and doing things the right way. I have no doubt that given the chance, he will make great things, and I hope to see him become a valued contributor to the Drupal community (especially once he's done with school and has free time again!). He's extremely responsible, and sharp as a tack. +1 from me!

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

@thegreat: You still need to upload the module here, as it is reported in Apply for contributions CVS access, and in the email you should have received.

tnightingale’s picture

tnightingale commented
StatusFileSize
new thegreat-Drupal-SoundCloud-2774235.tar_.gz185.98 KB

@kiamialuno - Sorry, was all ready to upload a tarball when I discovered a bug with installing my module alongside the autoload module (a dependency).

Anyway, problem solved now. Here it is :)

tnightingale’s picture

tnightingale commented
Status: Postponed (maintainer needs more info) » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented 
  1. function user_music($account) {
  drupal_set_title(check_plain($account->name) . "'s Music");
  
  $scuser = SoundCloudUser::getUser($account->uid);

    The title should be passed to t(), and the string should use placeholders (which are necessary because the first argument of the function must be a literal string.

  2. See the Drupal coding standards to understand how a module code should be written. In particular see the namespace respect, and how the if statement should be written. 
  3.       'uid' => array(
        'description' => t("The Drupal ID of the user account associated with the SoundCloud account."),
        'type' => 'int',
        'not null' => TRUE
      ),

    Schema descriptions should not be passed to t() anymore. See system_schema() for an example of what done by Drupal core code. 

  4.     $link = l(t('here'), "user/{$account->uid}/edit/music");
    drupal_set_message(t("You need to set a SoundCloud account. You can do that !here", array('!here' => $link)), 'error');

    l() is not used together t(); that is reported in the documentation page for t(), which reports the following text:

    Here is an example of incorrect usage of t():

    $output .= t('<p>Go to the @contact-page.</p>', array('@contact-page' => l(t('contact page'), 'contact')));

    Here is an example of t() used correctly:

    $output .= '<p>'. t('Go to the <a href="@contact-page">contact page</a>.', array('@contact-page' => url('contact'))) .'</p>';
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work
tnightingale’s picture

tnightingale commented
Status: Needs work » Needs review
StatusFileSize
new thegreat-Drupal-SoundCloud-ddaba4d.tar_.gz185.96 KB

Thanks kiamlaluno,

I have fixed the issues you mentioned above and some others after having a read through the coding standards page.

New tarball attached.

tnightingale’s picture

tnightingale commented
StatusFileSize
new thegreat-Drupal-SoundCloud-9bd1e9a.tar_.gz185.96 KB

Fixed a coding standards warning surfaced by the Coder module.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

Welcome on board!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kristofferrom’s picture

kristofferrom
He/him/his
commented
Component: Miscellaneous » miscellaneous
Category: task » feature
Priority: Normal » Major
Status: Closed (fixed) » Active

Is this drupal 7 compatible?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Category: feature » task
Status: Active » Closed (fixed)

This is not the issue queue for a module; it's the issue queue for CVS applications. If you need information about the module, you need to ask its author.