Closed (fixed)
Project:
GeSHi Filter for syntax highlighting
Version:
5.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
1 Jun 2006 at 09:46 UTC
Updated:
26 Sep 2007 at 22:31 UTC
when we have < inside <code> tags it won't be escaped (submit by dvessel in http://drupal.org/node/66110)
Comments
Comment #1
dvessel commentedLatest in cvs fixes this when the 'highlight inline code' is enabled. It's a checkbox inside 'admin/filters/x/configure' where 'x' is the input format you have set for geshifilter.
Comment #2
dvessel commentedOne question..
How did you enabled highlighting for this? I thought it wasn't supported in geshi. :) I'm not looking for a technical answer. Just wondering if it will break anything.
Comment #3
pitpit commentedand if you put geshifilter before 'HTML filter' in your input format >> rearrange.
But it stills be a bug in others case.
Actually geshi can highlight anything. When a <codegt; is found geshifilter tell geshi to not add pre or div container using GESHI_HEADER_NONE (see geshi documentation) and keep <codegt; tags in place.
dpdev
Comment #4
soxofaan commentedComment #5
soxofaan commentedI can reproduce this with geshifilter.module version 1.22 (related to 5.x-2.x branch) as follows:
usage of input filter with only the geshi filter enabled (the point is to have no HTML filter)
default language: no syntax highlighting
input of source code without a language set (e.g. "<code> a = b < c </code>)
result: the "<" is not escaped to "<"
Comment #6
soxofaan commentedComment #7
soxofaan commentedFixed by http://drupal.org/cvs?commit=81043 in 5.x-2.x branch.
When "no highlighting, just add a code container" is enabled as default highlighting mode, the ">" and "<" are encoded correctly (by usage of the plain text highlighting definition.
When "no highlighting, do nothing" is enabled, the filter does nothing, so the ">" and "<" are in the hands of other filters.
Comment #8
(not verified) commented