Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I doubt we could slip this into D7 at this point so I'm marking it for D8. For multi-insert queries, it would be quite useful to know how many records they currently have queued up. The natural way to do that is to simply have InsertQuery implement the Countable interface, and return the number of records it has queued to insert.
Easy patch. Too bad we have to wait for D8, but at least it will give us something to look forward to. :-)
Comment | File | Size | Author |
---|---|---|---|
#18 | 664722-18.patch | 3.67 KB | amateescu |
#15 | interdiff.txt | 2.29 KB | amateescu |
#15 | 664722-15.patch | 3.65 KB | amateescu |
#10 | 664722-10.patch | 1.36 KB | amateescu |
#6 | interdiff.txt | 1.36 KB | amateescu |
Comments
Comment #1
EvanDonovan CreditAttribution: EvanDonovan commented@Crell: Still planning to write a patch for this?
Comment #2
Crell CreditAttribution: Crell commentedI'd still like to see it happen. You are welcome and encouraged to beat me to it. :-)
Comment #3
Crell CreditAttribution: Crell at Palantir.net commentedComment #4
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedToo bad this issue was forgotten :)
Comment #5
Crell CreditAttribution: Crell at Palantir.net commentedWhy not put the method in the trait now?
Comment #6
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedBecause of limited brain space at midnight :/
Comment #7
Crell CreditAttribution: Crell at Palantir.net commentedSetting to RTBC but leaving at 8.1. Like a boss, er, something...
Comment #10
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedRerolled and back to RTBC, per the boss in #7 :D
Comment #12
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedThat was a random testbot failure.
Comment #14
catchCould still go into 8.1.x, but to do that could use test coverage.
Comment #15
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedSure thing :)
Comment #16
Crell CreditAttribution: Crell at Palantir.net commentedThat's probably more than we need, but gets the job done.
Comment #17
catchNeeds a re-roll... test has moved.
Comment #18
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedRerolled.
Comment #20
catchCommitted/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!