I think groupby-support should be tested. If its full tested the port to drupal7 is somehow easier, because we know, whether the port works.

The first file is a diff to DRUPAL-6--3 the second to this patch http://drupal.org/files/issues/views-simpletest_1.patch

If someone is familiar with git he could use also
http://github.com/dereine/drupal-views/tree/simpletest or
http://github.com/dereine/drupal-views/tree/test-group-by

Currently the problem is that the view in testAggregateCount produces a result of 3...1 instead of 3...2

CommentFileSizeAuthor
#1 views-test-groupby_DRUPAL-6--3.patch27.32 KBdawehner
#1 views-test-groupby_simpletest.patch8.66 KBdawehner
views-test-groupby_simpletest.patch4.21 KBdawehner
views-test-groupby_DRUPAL-6--3.patch22.88 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new views-test-groupby_simpletest.patch8.66 KB
new views-test-groupby_DRUPAL-6--3.patch27.32 KB

Updated patches.

Added a non-working groupby-fields

merlinofchaos’s picture

merlinofchaos commented
Status: Needs work » Fixed

Committed both; I know group by tests will change, but I figure once we start adding tests we'll just keep getting a bunch more.

dawehner’s picture

dawehner
Primary language German
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Fixed » Patch (to be ported)

Update status.

It would be cool to have the tests is something like a sync. At least this initial version.

dawehner’s picture

dawehner
Primary language German
commented

More tests for groupby http://drupal.org/node/664410

dawehner’s picture

dawehner
Primary language German
commented

oh no, i got into endless recursion.

I think http://drupal.org/node/679714 is a link to stop it.

dawehner’s picture

dawehner
Primary language German
commented
Status: Patch (to be ported) » Fixed

this was commited

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.