atrasatti [atrasatti]

I don't know what you mean by preview, but Apply for contributions CVS access reports that

Many people write good motivation messages and then mess it up right at the end with "here's a link to my contribution, it's about 75% done". Please, when applying for a CVS account supply a link to your contribution that you believe is complete. Attempting to review uncompleted work is difficult and time consuming (yes, remove all those dpr() and self reminder comments ;) Reviewing completed work is much simpler as there is already a level of expectation in the reviewer. Try to make our job of reviewing your work a joy.

1. 		<script type="text/javascript" src="../resources/scripts/templates.js" />
   		<script type="text/javascript">
   			function init() {
   				var myStyleTweaks = new StyleTweaker();
   				myStyleTweaks.add("Series60/5.0", "../resources/styles/tweaks/S605th.css");
   				myStyleTweaks.add("Series60/3.2", "../resources/styles/tweaks/S603rdFP2.css");
   				myStyleTweaks.add("AppleWebKit/420+", "../resources/styles/tweaks/S406th.css");
   				myStyleTweaks.add("N900", "../resources/styles/tweaks/maemo.css");
   				myStyleTweaks.add("Firefox/3.0a1 Tablet browser 0.3.7", "../resources/styles/tweaks/maemo.css");
   				myStyleTweaks.add("Opera Mini/4", "../resources/styles/tweaks/operamini.css");
   				myStyleTweaks.tweak();
   			}
   			addEvent("onload",init);
   		</script>
   

   There is the function drupal_add_js(), but in this case you can declare the JavaScript files used by the theme into its .info file.
   It is better to always include JavaScript code from a file, when the code is more than 1 line of code.

2. The file LICENSE.txt needs to be removed; Drupal.org CVS doesn't allow to commit that file.
3. Files available from third-party sites should not be included in Drupal.org CVS.

4. 	<title><?php print $head_title ?></title>
   

   Always use the line terminator; the line should be written as <?php print $head_title; ?>.

1. /*!
    * Nokia Mobile Web Templates v0.5
    * http://forumnokia.com
    *
    * Copyright (c) 2009 Forum Nokia
    *
    */
   

   I think that file can be downloaded from http://forumnokia.com; the file then doesn't report the license, which could be not compatible with the license applied to all the files committed in CVS.

2. 				<?php
   				$logo = file_create_path($_SERVER['DOCUMENT_ROOT'].$logo);
   				if ($logo && !is_null($logo) && is_file($logo)) {
   					print '<a id="sitelogo" title="' . $site_slogan . '" href="' . check_url($front_page) . '"><img src="'. check_url($logo) .'" /></a>';
   				}
   

   The code is not respecting the settings for the logo set for the theme.

3. 		<script type="text/javascript">
   			function init() {
   				var myAccordionList = new AccordionList("accordion");
   				var myStyleTweaks = new StyleTweaker();
   				myStyleTweaks.add("Series60/5.0", "'.$tweaks_path.'S605th.css");
   				myStyleTweaks.add("Series60/3.2", "'.$tweaks_path.'S603rdFP2.css");
   				myStyleTweaks.add("AppleWebKit/420+", "'.$tweaks_path.'S406th.css");
   				myStyleTweaks.add("N900", "'.$tweaks_path.'maemo.css");
   				myStyleTweaks.add("Firefox/3.0a1 Tablet browser 0.3.7", "'.$tweaks_path.'maemo.css");
   				myStyleTweaks.add("Opera Mini/4", "'.$tweaks_path.'operamini.css");
   				myStyleTweaks.tweak();
   			}
   			addEvent("onload",init);
   		</script>
   

   What is the difference between executing the code inline as it is, and including the JavaScript code with

   ? I guess it would do the same thing in both the cases. Drupal output is XHTML, which means a script cannot be added using the HTML tag you used. If you notice how Drupal includes inline JavaScript, you will notice that the XHTML code is a little different.

4. 		$vars['styles'] = _mobileplugin_filter_css($vars['css']);
   		$vars['scripts'] = _mobileplugin_filter_js();
   		$vars['bodyclasses'] = 'mobile' . _mobileplugin_add_class();
   		$scaled_logo = _mobileplugin_image_scaled($vars['logo'], 30, 30);
   		if (!is_array($scaled_logo)) {
   			$vars['logo'] = $scaled_logo;
   		}
   

   As themes cannot report their dependency from a module, the code should first verify if that module is enabled, before to call those functions.

5. 	if ($device_class === false) {
   		$nokia_detection = theme_get_setting('nokia_mobile_native');
   		if ($nokia_detection) {
   			$device_class = _nokia_mobile_device_detection();
   		} else {
   			// Use the global variable set by mobileplugin_init()
   			global $mobileplugin_group;
   			$device_class = $mobileplugin_group;
   		}
   	}
   

   See the Drupal coding standards to understand how a module code should be written. In particular see how the code should be formatted, and how constant names are written.

What I reported about files available from third-party sites is still valid.
On the coding standards, TRUE, FALSE, and NULL are considered constants, and they should be written in upper case letter, independently from the fact PHP is not case sensitive.

Considering that there are projects in CVS as jQuery UI, which doesn't commit in CVS files taken from another project, I would think that avoiding to commit in CVS files available from third-party site is possible.

Remember that the default values for the theme settings are written in the .info file.