Any variables that have been overridden in settings.php by setting $conf['variable_name'] are completely ignored when strongarm (v2) is enabled. I'm marking this as critical because many sites and modules rely on the ability to override variables directly in settings.php - this allows different environments to have different variables (dev, stage, live etc).

Variable overrides in settings.php should take precedence.

Comments

mrfelton’s picture

Status: Active » Needs review
StatusFileSize
new1.18 KB

Attached patch compares what is in the database with what is in $conf by default (which I think is created during the bootstrap?) If they are different, that means that the variable has been overridden in settings.php, and if that is the case that version of the variable takes precedence.

mrfelton’s picture

Status: Needs review » Needs work

Not quite... complex variables weren't being set up properly - probably because they are serialised in the db, so my comparison was wrong...

mrfelton’s picture

This version should be better.

yhahn’s picture

Status: Needs work » Fixed

Thanks, committed: http://drupal.org/cvs?commit=303508. I've reflected this change in the admin UI as well (hardcoded vars are marked as such and cannot be reverted.)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.