I gave Boost a try on my slimmed-down VPS, where the PHP install doesn't have the Zlib library installed. I disabled Gzip encoding in Boost. However, the server error logs were filling with complaints about a call to the undefined function gzencode() on line 2699. On further inspection, it looks like Boost calls gzencode() on data it is about to cache, regardless of whether it's going to cache the Gzipped version or the uncompressed version:


  $compressed_buffer = gzencode($buffer, 9);
  foreach ($filenames as $key => $values) {
    if ($key == 'gzip') {
      $data = $compressed_buffer;
    }
    else {
      $data = $buffer;
    }
    // We never see $compressed_buffer again

What's up with that? Patch attached.

CommentFileSizeAuthor
boost-stop-gzipping.patch497 bytesGarrett Albright
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

Status: Needs review » Fixed

It's what happens when you rewrite the function multiple times, trying to make it better; this was a pretty dub error though. Thanks for seeing this.
Committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.