The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Range directives of sub-queries are not honored, because we add the LIMIT directive at query time, not when building the query.
This bug is blocking proper fix of #314349: PDO Exception when having too much comments.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | range-comment.patch | 669 bytes | Crell |
| #1 | 653926-range-on-subqueries.patch | 2.86 KB | damien tournoud |
Comments
Comment #1
damien tournoud commentedThe good news is that all our supported database engines actually support the same syntax
LIMIT $number OFFSET $offset. Let's simply use that. This patch does that, and adds an additional test for range on sub-queries.Comment #2
chx commentedWell, OK but I would love to see then the normal range queries use this construct too -- in another isuse of course.
Comment #3
Crell commentedMakes sense, especially since drivers that need to do it differently can just override that method if they need to build the string differently. (Oracle, MS SQL, etc.) Might we want to document that the LIMIT method is not standard SQL but happens to be the method supported by most OSS databases? Just for completeness? Should be a simple comment addition.
Comment #4
dries commentedCommitted to CVS HEAD. Thanks!
Comment #5
Crell commentedRe-opening to tweak the comment. (I should have set it CNW before, sorry.)
Comment #6
Crell commentedComment tweaks as mentioned.
Comment #7
ceardach commentedThe documentation in the patch is good and should be committed.
Comment #8
webchickCommitted to HEAD. Thanks!