nachinius [nachinius]

1.       'label' => t('Embedded Scribd Document'),
   

   Strings used in user interface should have the first word in capital case, and the other words in lower case (with the exception of proper nouns, adjectives derived from proper nouns, and acronyms).

2. /**
    * Implementation of hook_widget_settings (CCK)
    **/
   function emscribd_widget_settings($op, $widget) {
     switch($op) {
     case 'form':
     case 'validate':
     case 'save':
     }
   }
   

3. See the Drupal coding standards to understand how a module code should be written. In particular, see how constants should be written.

Drupal consider constants also NULL, TRUE, and FALSE.

      if (@count($info['fields'])) {
        foreach ($info['fields'] as $field_name => $field) {
          if (in_array($field['type'], array('emscribd'))) {
            $fields[$field_name] = isset($field['widget']['label']) ? $field['widget']['label'] : $field_name;
          }
        }
      }

The errors suppressor operator should be used when it is really necessary; there isn't the need to use it in such case.

Strings used in user interface should have the first word in capital case, and the other words in lower case (with the exception of proper nouns, adjectives derived from proper nouns, and acronyms).

I am attaching a patch, I hope this is ok.

We review the code globally. Would who review the code be supposed to take the old file, patch it, and then review it?
Considering that to create the patch you first modified the original file(s), I think that it would be kind for who review the code to upload the full archive.

I was not upset. I was trying to give a reason of why we don't review patches; I think that explaining the reason why something is done in a way is better than simply saying no, we don't proceed so.

It's me who needs to apologize, if I seemed upset.