Pager settings are not stored

The problem was that views_display_plugin::option_definition was defining the 'items_per_page' (this should be removed in pluggable pagers patch) so, when init() function called $this->get_option('items_per_page') the default value was loaded and not the defined values from UI.

Hm. I think this can't be removed, because otherwise old format stuff will not be properly converted. Instead we must add 'export' => FALSE to these lines. It should be really easy to test this, but I'm pretty sure I had to leave those definitions to make sure that the data would be read properly.

Yes it make sense. So, only perform the conversion if the items_per_page, offset, or use_pager doesn't contains default values.

tagging

Yes, you was right, I only tested it with a default display, but when I click override this doesn't work anymore. New patch, here is my view export, it seems to be working fine now.

$view = new view;
$view->name = 'test1';
$view->description = '';
$view->tag = '';
$view->view_php = '';
$view->base_table = 'node';
$view->is_cacheable = FALSE;
$view->api_version = 2;
$view->disabled = FALSE; /* Edit this to true to make a default view disabled initially */

/* Display: Defaults */
$handler = $view->new_display('default', 'Defaults', 'default');
$handler->display->display_options['access']['type'] = 'none';
$handler->display->display_options['cache']['type'] = 'none';
$handler->display->display_options['exposed_form']['type'] = 'basic';
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['pager']['options']['items_per_page'] = '30';
$handler->display->display_options['pager']['options']['offset'] = '';
$handler->display->display_options['pager']['options']['id'] = '0';
$handler->display->display_options['style_plugin'] = 'default';
$handler->display->display_options['row_plugin'] = 'fields';
/* Field: Nodo: Nid */
$handler->display->display_options['fields']['nid']['id'] = 'nid';
$handler->display->display_options['fields']['nid']['table'] = 'node';
$handler->display->display_options['fields']['nid']['field'] = 'nid';
$handler->display->display_options['fields']['nid']['alter']['alter_text'] = 0;
$handler->display->display_options['fields']['nid']['alter']['make_link'] = 0;
$handler->display->display_options['fields']['nid']['alter']['trim'] = 0;
$handler->display->display_options['fields']['nid']['alter']['word_boundary'] = 1;
$handler->display->display_options['fields']['nid']['alter']['ellipsis'] = 1;
$handler->display->display_options['fields']['nid']['alter']['strip_tags'] = 0;
$handler->display->display_options['fields']['nid']['alter']['html'] = 0;
$handler->display->display_options['fields']['nid']['hide_empty'] = 0;
$handler->display->display_options['fields']['nid']['empty_zero'] = 0;
$handler->display->display_options['fields']['nid']['link_to_node'] = 0;

/* Display: Página */
$handler = $view->new_display('page', 'Página', 'page_1');
$handler->display->display_options['defaults']['pager'] = FALSE;
$handler->display->display_options['pager']['type'] = 'full';
$handler->display->display_options['pager']['options']['items_per_page'] = '25';
$handler->display->display_options['pager']['options']['offset'] = '';
$handler->display->display_options['pager']['options']['id'] = '0';
$handler->display->display_options['path'] = 'test1';

Plz exmplain the issue.
" 1. Create a view
2. Change the pager settings, for example the items per page
3. Export it/change the pager settings again, and you will see that nothing changed
"

Did u save the view after changing pager settings ?

@figover, dereine is the comaintainer of views for Drupal 7, he knows what is he doing :)

@dereine, I'm changing the status of this issue to critical because we need this fixed to test

#324092: Expose: Items per page and Offset
#268023: Limiting total number of items....

Can you provide a more detailed information the steps to reproduce the bug?

I'm doing this:

Apply the patch.
Create a view:
Set Pager -> Full pager, settings changed
Create a new display
Override
Set Pager -> Mini pager, settings changed

And it is working fine... this is weird

The good thing is we have ultra tested this issue :)

So I finally can replicate, when a views was saved with previous values, like Views Bulk Operations with admin/content/node2 contains a value different to 10 as items per page, so it is not the default value. When the view is edited views_plugin_display::init() converts the old values into a new plugin pager, but, items_per_page, offset and use_pager are still here. So when the views is saved, both, new and old values are saved, but then. Views is initialized again, and since old values are still there, pager is loaded as a conversion of the old values.

Solution?

+      // Unset the previous options
+      // After edit and save the view they will be erased
+      $this->set_option('items_per_page', NULL);
+      $this->set_option('offset', NULL);
+      $this->set_option('use_pager', NULL);

works like a charm! thanks!

Ok, tests (even with fails) and patch committed to 6.x; needs to be rerolled for 7.x -- note that I added a missing comma in the patch in an array().

untag